This repository was archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[ios] adapt Mapbox Streets–sourced layers for user preferred language #9582
Merged
fabian-guerra
merged 9 commits into
release-ios-v3.6.0-android-v5.1.0
from
fabian-adapt-user-language-7031
Aug 1, 2017
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6a1c515
[ios] Update label localization
fabian-guerra 6b36d60
[ios, macos] Move MGLVectorSource+MBXAdditions.h to darwin.
fabian-guerra 8c2e18e
[ios, macos] Adapt Mapbox Streets to the user preferred language.
fabian-guerra d594986
[ios, macos] Clarify style localization documentation.
fabian-guerra f54923d
[ios, macos] Update localization examples
fabian-guerra 110757c
[ios, macos] Add style language reset to original.
fabian-guerra e42a599
[ios, macos] Update changelogs.
fabian-guerra 5ececfb
[ios, macos] Rename Vector Source Additions to MGL standard.
fabian-guerra 2c77056
[ios, macos] Add suport for stop localization.
fabian-guerra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
.../macos/app/MGLVectorSource+MBXAdditions.m → ...darwin/src/MGLVectorSource+MGLAdditions.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also replace/remove
-bestLanguageForUser?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@friedbunny We could but in the
MBXViewControllerwe would have to explicitly import"MGLVectorSource+MBXAdditions.h"is that ok?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as
-bestLanguageForUsermatches the implementation ofMGLVectorSource.preferredMapboxStreetsLanguage, there should be no need to make that header public to import it. Displaying the language that would be used is a pretty narrow use case that I wouldn’t expect any other application to need.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@friedbunny @1ec5 it does matches the implementation so I don't think we need to get rid of this.