This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Update example of camera zoom function on a symbol layer.#9743
Merged
Conversation
Guardiola31337
suggested changes
Aug 10, 2017
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Minor detail. What about replacing magic numbers (literals in general including Strings) with constants with a particular meaning?
tobrun
force-pushed
the
tvn-update-change-symbol
branch
from
ef21bb2 to
171a0cb
Compare
Member
Author
|
@Guardiola31337 Great catch, code has been updated. |
20 tasks
20 tasks
20 tasks
This was referenced Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the AddRemoveMarkerActivity with a SymbolLayer implementation that does the same with a symbollayer and with scale: