This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Don't recycle bitmap for icon reuse.#9966
Merged
Merged
Conversation
ivovandongen
approved these changes
Sep 12, 2017
Contributor
ivovandongen
left a comment
ivovandongen
left a comment
There was a problem hiding this comment.
Great! Thanks for picking this up so quickly.
20 tasks
20 tasks
20 tasks
This was referenced Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9936, regression from #9643.
In the mentioned PR, I assumed it was save to recycle bitmaps when no longer in use but since the android resources system caches resources, we aren't allowed to make that assumption. From this PR forward it will be the end-users responsibility to recycle bitmaps if they want to free memory.