StyleManagerProtocol pt3 (Updates cluster, image, light, terrain and custom geometry source APIS)#321
Merged
Merged
Conversation
julianrex
added
the
breaking change ⚠️
julianrex
changed the title
| /// | ||
| /// - Throws: | ||
| /// An error describing why the operation was unsuccessful. | ||
| public func setTerrain(_ terrain: Terrain) throws { |
Contributor
There was a problem hiding this comment.
I think we decided to make terrain a computed property with an explict setter / getter (and fatally erroring if unsuccessful). Same with Light.
Contributor
Author
There was a problem hiding this comment.
Yep, will address in the next PR :) Edit: this may not be possible at this moment.
|
|
||
| print("TODO: \(String(describing: identifier)) \(geometry) \(String(describing: properties))") | ||
|
|
||
| return nil |
Contributor
There was a problem hiding this comment.
Hmm, is this something that we're going to add support for later?
nishant-karajgikar
approved these changes
May 5, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #320, #317
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
Write tests for all new functionality. If tests were not written, please explain why.Follow up PR.mapbox-maps-ioschangelog:<changelog>Refactors cluster, image, light, terrain and custom geometry source style APIs</changelog>.Summary of changes
This is PR 3 of N (see #320):
User impact (optional)