Add Directions API beta query parameters example#106
Merged
Conversation
jill-cardamon
commented
May 4, 2021
| let items = [URLQueryItem(name: "depart_at", value: departureTime)] | ||
| print("!!! departure time: \(String(describing: departureTime))") | ||
| if let queryItems = super.urlQueryItems as [URLQueryItem]? { | ||
| print("!!! queryItems: \(queryItems)") |
Contributor
Author
There was a problem hiding this comment.
Remember to remove print statements and comments.
jill-cardamon
force-pushed
the
jill/beta-query-parameters-91
branch
from
6b26740 to
8211d8a
Compare
S2Ler
reviewed
Jul 22, 2021
|
|
||
| startButton.bottomAnchor.constraint(equalTo: self.view.safeAreaLayoutGuide.bottomAnchor, constant: -20).isActive = true | ||
| startButton.centerXAnchor.constraint(equalTo: self.view.centerXAnchor).isActive = true | ||
| view.setNeedsLayout() |
Contributor
There was a problem hiding this comment.
I don't think it is necessary. It will be due to layout automatically.
| startButton.isHidden = true | ||
| view.addSubview(startButton) | ||
|
|
||
| startButton.bottomAnchor.constraint(equalTo: self.view.safeAreaLayoutGuide.bottomAnchor, constant: -20).isActive = true |
Contributor
There was a problem hiding this comment.
nit: There is a nice short cut to active constraints:
NSLayoutConstraint.active([
/* a list of constraints */
])
Comment on lines
+170
to
+173
| let item = [URLQueryItem(name: "depart_at", value: departureTime)] | ||
| if let queryItems = super.urlQueryItems as [URLQueryItem]? { | ||
| return queryItems + item | ||
| } |
Contributor
There was a problem hiding this comment.
super.urlQueryItems is always [URLQueryItem]. There is no need for a cast.
Suggested change
| let item = [URLQueryItem(name: "depart_at", value: departureTime)] | |
| if let queryItems = super.urlQueryItems as [URLQueryItem]? { | |
| return queryItems + item | |
| } | |
| var items = super.urlQueryItems | |
| items.append(URLQueryItem(name: "depart_at", value: departureTime)) | |
| return items |
added 6 commits
July 27, 2021 10:31
jill-cardamon
force-pushed
the
jill/beta-query-parameters-91
branch
from
4197c6e to
e33768b
Compare
S2Ler
approved these changes
Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an example to demonstrate how to use the new Directions API beta query parameters. This issue closes #91.