Remove Objective-C compatibility; adopt Swift language features#2230
Merged
Conversation
571ebde to
596fe6f
Compare
1ec5
reviewed
Sep 25, 2019
Contributor
Author
|
Some lessons learned so far: There are a few unanticipated complications that may impact our refactoring objectives. Namely:
|
Merged
1 task
added 13 commits
October 15, 2019 14:58
New errors have cropped up, but these are all moot because they stem from OBJ-C code, which will be removed. (the OBJ-C example code no longer recognizes anything from the SDK)
1ec5
reviewed
Oct 15, 2019
| XCTAssertTrue(dependencies.navigationService.eventsManager.usesDefaultUserInterface, "MapboxCoreNavigationTests should have an implicit dependency on MapboxNavigation due to running inside the Example application target.") | ||
| } | ||
| // func testDefaultUserInterfaceUsage() { | ||
| // XCTAssertTrue(dependencies.navigationService.eventsManager.usesDefaultUserInterface, "MapboxCoreNavigationTests should have an implicit dependency on MapboxNavigation due to running inside the Example application target.") |
Contributor
There was a problem hiding this comment.
This test should be restored and fixed.
added 3 commits
October 15, 2019 15:02
…ere are some issues with some other tests.
Contributor
|
I got a crash arriving at the final destination: The error is: Please audit the storyboards for any Objective-C class names. |
Serious crashes due to stale references in storyboards.
Taking Minh's PR Suggestions Co-Authored-By: Minh Nguyễn <mxn@1ec5.org>
Co-Authored-By: Minh Nguyễn <mxn@1ec5.org>
# Conflicts: # CHANGELOG.md
1ec5
approved these changes
Nov 20, 2019
4 tasks
This was referenced Dec 20, 2019
This was referenced Jan 15, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress.
Running Checklist:
@objcattributes andMBclass prefixesCMapboxDirectionstarget from SPM distribution ofMapboxDirections.swiftReplace magic default values with optionalsFixes #2231.