Migrate to Swift 5#2232
Merged
Merged
Conversation
Contributor
Author
|
The migration introduced a number of warnings: Some of these issues can be addressed by removing |
Contributor
Author
|
Some of the builds are failing because Swift 5 isn’t supported in the Xcode 10.1 / iOS 9.3 toolchain. #2206 would remove this build in favor of an Xcode 11 / iOS 13 toolchain. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated to Swift 5, for now using the Swift 5.0 migrator in Xcode 10. The idea is to have as clean a slate as possible for the Objective-C obsolescence work in #2231.
Recap:
Migrate to Swift 5.1– too soon to require Xcode 11switchexhaustiveness warningsBlocked by #2206.
/cc @mapbox/navigation-ios