Cleanup of Deprecated / Obsoleted Symbols#2297
Merged
Merged
Conversation
…gs, resulting in wonky IDE behavior.
1ec5
reviewed
Jan 6, 2020
added 6 commits
January 9, 2020 16:57
…olete, if possible.
# Conflicts: # Cartfile.resolved
1ec5
reviewed
Jan 10, 2020
Contributor
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
Changelog entries will help guide developers migrating to v1.0, given all the other changes they’ll have to account for.
|
|
||
| SPEC REPOS: | ||
| trunk: | ||
| https://github.com/cocoapods/specs.git: |
Contributor
Lets put the filename in backticks.
JThramer
force-pushed
the
jerrad/symbol-silliness
branch
from
6b5e219 to
3b48797
Compare
1ec5
approved these changes
Jan 10, 2020
Contributor
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
One stylistic comment, but I can massage that in master if you need to land this PR first.
| * The `MapboxVoiceController` and `RouteVoiceController` now emit `SpeechError`s instead of an `NSError` object. ([#2230](https://github.com/mapbox/mapbox-navigation-ios/pull/2230)) | ||
| * Added the `VoiceControllerDelegate.voiceController(_:didFallBackTo:becauseOf:)` method for detecting when the voice controller falls back to `AVSpeechSynthesizer`. ([#2230](https://github.com/mapbox/mapbox-navigation-ios/pull/2230)) | ||
|
|
||
| ### Obsoletion & Removal |
Contributor
There was a problem hiding this comment.
I’d prefer if we moved these entries into the existing topic-based section headers. It’s a bit overwhelming for a developer to see a wall of obsoletion messages, but easier to digest if they know that some are UI-related, others are in Core Navigation, etc.
Contributor
Author
There was a problem hiding this comment.
Done, how does that look?
1ec5
added
the
backwards incompatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue where deprecated symbols are
renamed:to improper things, resulting in unexpected IDE behavior. Fixes #2289./cc @mapbox/navigation-ios