Update nav native dependency to 9.2.1 version#2404
Merged
avi-c merged 20 commits intoJun 22, 2020
Conversation
…according to its type name.
5537cf2 to
ede919a
Compare
ba2322c to
4a99d89
Compare
2f23be9 to
026f599
Compare
4a99d89 to
a70ddd3
Compare
1ec5
reviewed
Jun 17, 2020
Contributor
1ec5
left a comment
There was a problem hiding this comment.
In addition to the following feedback, I took the liberty of updating the changelog to reflect an upgrade to MapboxNavigationNative that also upgraded the internal Valhalla dependency.
aaa8a0f to
439ed09
Compare
Contributor
|
@dersim-davaod did you investigate failed CI tests? |
1ec5
reviewed
Jun 17, 2020
Contributor
1ec5
left a comment
There was a problem hiding this comment.
We should also update README.md and custom-navigation.md to mention the netrc-based workflow for obtaining the MapboxNavigationNative dependency.
Contributor
|
We need to investigate this crash: |
1ec5
reviewed
Jun 18, 2020
| run: | ||
| name: Prepare | ||
| command: | | ||
| # if [ $(carthage outdated | grep -cF "latest Carthage version") -eq 0 ]; then brew update && brew upgrade carthage || true; fi |
Contributor
There was a problem hiding this comment.
A couple of these commits can be rewritten out of the history.
439ed09 to
336942b
Compare
1ec5
reviewed
Jun 22, 2020
Contributor
|
The CocoaPods installation test is failing to install MapboxNavigationNative from Bintray: |
Contributor
|
This PR was merged by accident, so we’re redoing it in #2412. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR in scope of sequential update with results into the state where we have latest nav-native dependency.
The changes is splitter to make the review process easier and faster. As soon as the current changes is merged, the next PR that upgrades to v11.0.3/v12.0.3 and 14.0.1 should be reviewed.
NOTE: As a reviewer I'd expect you to check at least the run-time with test application (Example or Example-CarPlay), enabling the application’s Enable Simulation option