Skip to content

Update nav native dependency to 9.2.1 version#2404

Merged
avi-c merged 20 commits into
release-v1.0-pre-registryfrom
dersim-davaod-update-nav-native-to-9.2.1
Jun 22, 2020
Merged

Update nav native dependency to 9.2.1 version#2404
avi-c merged 20 commits into
release-v1.0-pre-registryfrom
dersim-davaod-update-nav-native-to-9.2.1

Conversation

@dersim-davaod
Copy link
Copy Markdown
Contributor

@dersim-davaod dersim-davaod commented Jun 16, 2020

This is the first PR in scope of sequential update with results into the state where we have latest nav-native dependency.

The changes is splitter to make the review process easier and faster. As soon as the current changes is merged, the next PR that upgrades to v11.0.3/v12.0.3 and 14.0.1 should be reviewed.

NOTE: As a reviewer I'd expect you to check at least the run-time with test application (Example or Example-CarPlay), enabling the application’s Enable Simulation option

@dersim-davaod dersim-davaod added platform parity Required to keep on par with Android. - tests labels Jun 16, 2020
@dersim-davaod dersim-davaod added this to the v1.0.0 milestone Jun 16, 2020
@dersim-davaod dersim-davaod self-assigned this Jun 16, 2020
@dersim-davaod dersim-davaod changed the base branch from master to internal June 16, 2020 15:07
@dersim-davaod dersim-davaod force-pushed the dersim-davaod-update-nav-native-to-9.2.1 branch from 5537cf2 to ede919a Compare June 16, 2020 15:20
@dersim-davaod dersim-davaod force-pushed the dersim-davaod-update-nav-native-to-9.2.1 branch from ba2322c to 4a99d89 Compare June 16, 2020 16:28
@1ec5 1ec5 changed the base branch from internal to release-v1.0-pre-registry June 16, 2020 21:08
@1ec5 1ec5 force-pushed the release-v1.0-pre-registry branch from 2f23be9 to 026f599 Compare June 17, 2020 05:50
@1ec5 1ec5 force-pushed the dersim-davaod-update-nav-native-to-9.2.1 branch from 4a99d89 to a70ddd3 Compare June 17, 2020 05:51
Copy link
Copy Markdown
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the following feedback, I took the liberty of updating the changelog to reflect an upgrade to MapboxNavigationNative that also upgraded the internal Valhalla dependency.

Comment thread Cartfile Outdated
Comment thread MapboxCoreNavigation.podspec Outdated
Comment thread MapboxCoreNavigation/FixLocation.swift Outdated
Comment thread MapboxCoreNavigationTests/Extensions/RouteStateTests.swift Outdated
@dersim-davaod dersim-davaod force-pushed the dersim-davaod-update-nav-native-to-9.2.1 branch 2 times, most recently from aaa8a0f to 439ed09 Compare June 17, 2020 08:13
@IodaMikeMapbox
Copy link
Copy Markdown
Contributor

@dersim-davaod did you investigate failed CI tests?

Copy link
Copy Markdown
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update README.md and custom-navigation.md to mention the netrc-based workflow for obtaining the MapboxNavigationNative dependency.

@1ec5
Copy link
Copy Markdown
Contributor

1ec5 commented Jun 18, 2020

We need to investigate this crash:

Test Case '-[MapboxCoreNavigationTests.NavigationServiceTests testNineLeggedRouteForOutOfBounds]' started.

Example(7724,0x117f4ddc0) malloc: Heap corruption detected, free list is damaged at 0x60000157f030

*** Incorrect guard value: 38475276463501360

Example(7724,0x117f4ddc0) malloc: *** set a breakpoint in malloc_error_break to debug

2020-06-17 12:06:23.327 xcodebuild[7211:56146]  IDETestOperationsObserverDebug: Writing diagnostic log for test session to:

/Users/distiller/Library/Developer/Xcode/DerivedData/MapboxNavigation-gtrukiuwvhbmctfcsthejciepfao/Logs/Test/Run-MapboxCoreNavigation-2020.06.17_12-02-10-+0000.xcresult/Staging/3_Test/Diagnostics/MapboxCoreNavigationTests-B2DAC58D-5CCA-43DB-8E85-CC7AD107D7BD/MapboxCoreNavigationTests-75AAA591-F207-4A8A-A5D9-612CA5B41C4E/Session-MapboxCoreNavigationTests-2020-06-17_120623-nArVQh.log

2020-06-17 12:06:23.327 xcodebuild[7211:31715] [MT] IDETestOperationsObserverDebug: (1807C777-2E15-4B3B-8DEC-5D9F1F670F80) Beginning test session MapboxCoreNavigationTests-1807C777-2E15-4B3B-8DEC-5D9F1F670F80 at 2020-06-17 12:06:23.327 with Xcode 11E146 on target <DVTiPhoneSimulator: 0x7fb76b8c0010> {

		SimDevice: iPhone 8 Plus (1D3A97B4-9101-4B3D-A749-18499F08082A, iOS 13.4, Booted)

} (13.4 (17E255))

2020-06-17 12:06:23.331 xcodebuild[7211:31715] [MT] IDETestOperationsObserverDebug: (1807C777-2E15-4B3B-8DEC-5D9F1F670F80) Finished requesting crash reports. Continuing with testing.

2020-06-17 12:06:25.241157+0000 Example[7742:70949] Launching with XCTest injected. Preparing to run tests.

2020-06-17 12:06:25.339864+0000 Example[7742:70949] Waiting to run tests until the app finishes launching.



Restarting after unexpected exit, crash, or test timeout in NavigationServiceTests/testNineLeggedRouteForOutOfBounds(); summary will include totals from previous launches.

Comment thread .circleci/config.yml Outdated
run:
name: Prepare
command: |
# if [ $(carthage outdated | grep -cF "latest Carthage version") -eq 0 ]; then brew update && brew upgrade carthage || true; fi
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of these commits can be rewritten out of the history.

@dersim-davaod dersim-davaod force-pushed the dersim-davaod-update-nav-native-to-9.2.1 branch from 439ed09 to 336942b Compare June 22, 2020 13:59
Comment thread .circleci/config.yml Outdated
@1ec5
Copy link
Copy Markdown
Contributor

1ec5 commented Jun 22, 2020

The CocoaPods installation test is failing to install MapboxNavigationNative from Bintray:

-> Installing MapboxNavigationNative 9.2.1 (was 9.0.4)
 
 > Http download
 
   $ /usr/bin/curl -f -L -o /var/folders/1b/gl7yt7ds26vcyr1pkgld6l040000gn/T/d20200622-656-fo2aly/file.zip https://dl.bintray.com/content/mapbox/mapbox_collab/MapboxNavigationNative-ios-sdk-9.2.1.zip --create-dirs --netrc-optional --retry 2
 
     % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
 
                                    Dload  Upload   Total   Spent    Left  Speed
 
     0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 
   curl: (22) The requested URL returned error: 401 Unauthorized
 

 
[!] Error installing MapboxNavigationNative
 
[!] /usr/bin/curl -f -L -o /var/folders/1b/gl7yt7ds26vcyr1pkgld6l040000gn/T/d20200622-656-fo2aly/file.zip https://dl.bintray.com/content/mapbox/mapbox_collab/MapboxNavigationNative-ios-sdk-9.2.1.zip --create-dirs --netrc-optional --retry 2

@avi-c avi-c merged commit 06c1075 into release-v1.0-pre-registry Jun 22, 2020
@avi-c avi-c deleted the dersim-davaod-update-nav-native-to-9.2.1 branch June 22, 2020 16:25
@1ec5
Copy link
Copy Markdown
Contributor

1ec5 commented Jun 22, 2020

This PR was merged by accident, so we’re redoing it in #2412.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform parity Required to keep on par with Android. topic: directions topic: location

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants