Skip to content

Update nav-native to 12.0.3#2416

Closed
dersim-davaod wants to merge 8 commits into
release-v1.0-pre-registryfrom
dersim-davaod-update-nav-native-to-12.0.3
Closed

Update nav-native to 12.0.3#2416
dersim-davaod wants to merge 8 commits into
release-v1.0-pre-registryfrom
dersim-davaod-update-nav-native-to-12.0.3

Conversation

@dersim-davaod
Copy link
Copy Markdown
Contributor

@dersim-davaod dersim-davaod commented Jun 23, 2020

Upgraded to MapboxNavigationNative v12.0.3 as a followup to #2412.

/cc @mapbox/navigation-ios

@dersim-davaod dersim-davaod added release blocker Needs to be resolved before the release. topic: location documentation labels Jun 23, 2020
@dersim-davaod dersim-davaod added this to the v1.0.0 milestone Jun 23, 2020
@dersim-davaod dersim-davaod self-assigned this Jun 23, 2020
@1ec5 1ec5 requested review from 1ec5 and MaximAlien June 23, 2020 15:24
Comment on lines +51 to +54
# MapboxNavigationNative is built for arm64 and x86_64 architectures (i386 and armv7 are not present), so only 64-bit architecture is checked.
s.pod_target_xcconfig = {
'ARCHS[sdk=iphonesimulator*]' => '$(ARCHS_STANDARD_64_BIT)'
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2422 implements a similar workaround for Carthage.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this bit be in #2422 then?

@dersim-davaod dersim-davaod force-pushed the dersim-davaod-update-nav-native-to-12.0.3 branch 2 times, most recently from 33d05bb to bfaddb0 Compare June 25, 2020 15:02
@dersim-davaod dersim-davaod force-pushed the dersim-davaod-update-nav-native-to-12.0.3 branch from a621a07 to eb0f909 Compare June 26, 2020 14:45
@1ec5 1ec5 marked this pull request as ready for review July 2, 2020 21:55
@1ec5 1ec5 marked this pull request as draft July 2, 2020 21:56
@1ec5
Copy link
Copy Markdown
Contributor

1ec5 commented Jul 2, 2020

These changes have been incorporated into #2417, which upgrades all the way to v14.1.3.

@1ec5 1ec5 closed this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation release blocker Needs to be resolved before the release. topic: location

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants