Disable 32-bit architectures#2422
Merged
Merged
Conversation
MaximAlien
approved these changes
Jun 24, 2020
Member
|
Where are we tracking re-adding the missing archs? |
Contributor
Author
|
We’re tracking that issue upstream, internally, as part of the MapboxNavigationNative project. |
Contributor
|
This fix is blocking the metrics collecting task I am working on right now, because it require a release app to be built to run on a device, and missing ARMv7 arch is blocking the CI process. |
Member
|
Good catch @Udumft ! |
MapboxNavigationNative only supports 64-bit architectures, so MapboxCoreNavigation and MapboxNavigation can only support those architectures and not 32-bit architectures when building for the simulator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, MapboxNavigationNative is only available for arm64 and x86_64 architectures at the moment, despite the default and overwhelmingly common architectures being arm64, arm64e, armv7, and armv7s. Until we can upgrade to a release of MapboxNavigationNative that supports the right architectures, we’ll have to limit MapboxCoreNavigation and MapboxNavigation to the same set of architectures.
These changes only fix the issue for Carthage; #2416 includes a fix for CocoaPods.
/cc @mapbox/navigation-ios