Skip to content

Update private Carthage dependencies#2978

Merged
avi-c merged 1 commit into
mainfrom
ac-UpdateQuickNimble
May 8, 2021
Merged

Update private Carthage dependencies#2978
avi-c merged 1 commit into
mainfrom
ac-UpdateQuickNimble

Conversation

@avi-c
Copy link
Copy Markdown
Contributor

@avi-c avi-c commented May 5, 2021

Update version of Quick/Quick to v3.1.2 and Quick/Nimble to v9.0.1 for Xcode 12.5 support. Remove unnecessary Cedar dependency.

@MaximAlien MaximAlien requested a review from a team May 7, 2021 08:23
@MaximAlien MaximAlien added the build Issues related to builds and dependency management. label May 7, 2021
@MaximAlien MaximAlien added this to the v2.0.0 (GA) milestone May 7, 2021
@MaximAlien
Copy link
Copy Markdown
Contributor

Thanks for fixing these warnings in Xcode 12.5. I think we'll also have to update Package.swift.

@avi-c avi-c merged commit cf946f8 into main May 8, 2021
@avi-c avi-c deleted the ac-UpdateQuickNimble branch May 8, 2021 14:40
1ec5 pushed a commit that referenced this pull request Jul 22, 2021
…. Remove unnecessary Cedar dependency. (#2978)

Cherry-picked from cf946f8.
@1ec5 1ec5 mentioned this pull request Jul 22, 2021
Comment thread Cartfile.private
github "mapbox/MapboxGeocoder.swift" ~> 0.10
github "Quick/Quick" ~> 2.0
github "Quick/Nimble" ~> 8.0
github "CedarBDD/Cedar" ~> 1.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3034 restores the Cedar dependency to avoid a compiler error, though it does so using the mapbox-events-ios checkout instead of directly depending on the framework via Carthage.

@1ec5 1ec5 mentioned this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues related to builds and dependency management.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants