Restore availability macros to jazzy docset#3022
Merged
Merged
Conversation
SourceKit seems to finally generate a proper USR for symbols marked with availability macros.
1ec5
added
topic: documentation
build
MaximAlien
approved these changes
May 21, 2021
Contributor
Author
|
Cherry-picked to the main branch in 31e1605, because I needed this change in order to generate the jazzy docset for v1.4.1 using jazzy 0.13.6 and Xcode 12.4. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceKit seems to finally generate a proper USR for symbols marked with availability macros. The v2.0.0-beta.9 and v2.0.0-beta.10 documentation was successfully generated and published in ecb0d36 without the need for the workaround added in #1714, without the side effects noted in #1682 (comment). So I think we can simply remove the workaround at this point.
/cc @mapbox/navigation-ios