Implement API Diff workflow#3103
Merged
Merged
Conversation
Udumft
reviewed
Jun 22, 2021
Closed
azarovalex
reviewed
Jun 22, 2021
S2Ler
force-pushed
the
v2/s2ler/300-api-stability
branch
from
6e80a35 to
a455547
Compare
S2Ler
force-pushed
the
v2/s2ler/300-api-stability
branch
2 times, most recently
from
04ba839 to
7a83262
Compare
Contributor
Author
|
I found a way to do everything I wanted but without requiring branch convention. The idea is to have a file in the repository ( The caching is done by using |
S2Ler
force-pushed
the
v2/s2ler/300-api-stability
branch
2 times, most recently
from
224f77a to
400f562
Compare
S2Ler
force-pushed
the
v2/s2ler/300-api-stability
branch
2 times, most recently
from
bf117f3 to
4dd0439
Compare
S2Ler
force-pushed
the
v2/s2ler/300-api-stability
branch
2 times, most recently
from
6640a80 to
c21565a
Compare
Contributor
Author
|
@mapbox/navigation-ios I've addressed all the concerns. Let's land this PR right after we release RC to start tracking API breaking changes and find/fix edge cases if any. |
S2Ler
force-pushed
the
v2/s2ler/300-api-stability
branch
2 times, most recently
from
77878c7 to
2e1b87c
Compare
S2Ler
requested review from
a team,
Udumft and
azarovalex
and removed request for
a team
S2Ler
force-pushed
the
v2/s2ler/300-api-stability
branch
from
2e1b87c to
3169e6e
Compare
`.base_api` file contains a hash of the first major version release commit. High-level overview of the API Diff workflow: 1. Get API definition for the base API 2. Get API definition for the current API 3. Compare two APIs and report breaking changes Other workflow improvements: - Cache Carthage builds across workflow runs.
S2Ler
force-pushed
the
v2/s2ler/300-api-stability
branch
from
3169e6e to
e6cfb22
Compare
Udumft
reviewed
Sep 10, 2021
Udumft
approved these changes
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version in the first part of the branch name. See CONTRIBUTING.md for
more details.
There much limitation in CircleCI configs which make it difficult to
automate picking correct base API commit hash:
High-level overview of the API Diff workflow:
Other workflow improvements:
Authors: @Udumft @dersim-davaod @S2Ler