Update source localization files#3253
Merged
Merged
Conversation
azarovalex
reviewed
Aug 12, 2021
| @@ -1,27 +1,3 @@ | |||
| /* Format for speech string after completing a maneuver and starting a new step; 1 = distance */ | |||
Contributor
There was a problem hiding this comment.
Are these lines currently unused in the SDK?🤔
Contributor
Author
There was a problem hiding this comment.
Yes, it’s currently unused. The Directions API (online) and MapboxNavigationNative (offline) are responsible for providing speech strings.
MaximAlien
approved these changes
Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I split off an update to the source localization files from #3187 so we can land that PR next without any of the unused strings that apparently have translation issues anyways.
/cc @mapbox/navigation-ios