Disable filtering by navigation status origin#3265
Merged
Conversation
S2Ler
force-pushed
the
s2ler/3260-fix-nav-status
branch
from
140c0ae to
9c7ff2a
Compare
MaximAlien
approved these changes
Aug 17, 2021
S2Ler
force-pushed
the
s2ler/3260-fix-nav-status
branch
2 times, most recently
from
97a903c to
397eb43
Compare
1ec5
approved these changes
Aug 17, 2021
Fixed #3260 We are not supposed to filter out navigation statuses. If it breaking any functionality, we must fix it without filtering out all the events.
With non-ignored "legChange" status code, the leg change happens earlier
S2Ler
force-pushed
the
s2ler/3260-fix-nav-status
branch
from
397eb43 to
d1de23d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #3260
We are not supposed to filter out navigation statuses as per NavNative team. Android doesn't filter them out either.
If it breaking any functionality, we must fix it without filtering out all the events.