Skip to content

prevent form rerendering infinitely due to NaNs #7363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mscolnick merged 1 commit into from
Dec 2, 2025
Merged

prevent form rerendering infinitely due to NaNs #7363

mscolnick merged 1 commit into from
Dec 2, 2025

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Dec 1, 2025 •
edited
Loading

📝 Summary

Due to

console.log(NaN === NaN); // false

we need to use Object.is comparator.

I'm not sure where else this is happening, but it's unfortunate. Will check

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@Light2Dark Light2Dark requested a review from manzt as a code owner December 1, 2025 19:18
@vercel
Copy link

vercel bot commented Dec 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Dec 1, 2025 7:18pm

@Light2Dark Light2Dark marked this pull request as draft December 1, 2025 19:19
@Light2Dark Light2Dark added the bug Something isn't working label Dec 1, 2025
@mscolnick mscolnick mentioned this pull request Dec 1, 2025
Merged
@Light2Dark Light2Dark marked this pull request as ready for review December 2, 2025 10:17
@mscolnick mscolnick merged commit 1ebf082 into main Dec 2, 2025
31 of 35 checks passed
@mscolnick mscolnick deleted the sham/fix-inf-rerender-forms branch December 2, 2025 15:12
mscolnick added a commit that referenced this pull request Dec 3, 2025
@mscolnick @pre-commit-ci
fix: remove NaN from number plugin (#7364)
7a4da52 
Fixes #7352, although I think the underlying issue/fix is #7363

I plan to follow up with more tests/updates to other places where this
could crop up.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscolnick mscolnick mscolnick approved these changes

@manzt manzt Awaiting requested review from manzt manzt is a code owner

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Light2Dark @mscolnick