Resilience telemetry API (App-vNext#1138)

Author: martintmk

.editorconfig

@@ -18,3 +18,4 @@ tab_width = 2
 [*.cs]
 
 # Put any C# specific settings here
+dotnet_code_quality.CA1062.null_check_validation_methods = NotNull

.github/dependabot.yml

@@ -21,5 +21,6 @@ updates:
     - dependency-name: "System.ValueTuple"
     - dependency-name: "Microsoft.Extensions.Options"
     - dependency-name: "Microsoft.Extensions.Logging.Abstractions"
+    - dependency-name: "Microsoft.Extensions.Logging"
     - dependency-name: "System.Diagnostics.DiagnosticSource"
     - dependency-name: "System.Threading.RateLimiting"

src/Directory.Packages.props

@@ -7,6 +7,7 @@
     <PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.1" />
     <PackageVersion Include="Microsoft.Extensions.Caching.Memory" Version="7.0.0" />
     <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="7.0.0" />
+    <PackageVersion Include="Microsoft.Extensions.Logging" Version="7.0.0" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
     <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
     <PackageVersion Include="Moq" Version="4.18.4" />

src/Polly.Core.Tests/Registry/ResilienceStrategyRegistryOptionsTests.cs

@@ -0,0 +1,15 @@
+using Polly.Registry;
+
+namespace Polly.Core.Tests.Registry;
+public class ResilienceStrategyRegistryOptionsTests
+{
+    [Fact]
+    public void Ctor_EnsureDefaults()
+    {
+        ResilienceStrategyRegistryOptions<object> options = new();
+
+        options.KeyFormatter.Should().NotBeNull();
+        options.KeyFormatter(null!).Should().Be("");
+        options.KeyFormatter("ABC").Should().Be("ABC");
+    }
+}

src/Polly.Core.Tests/Registry/ResilienceStrategyRegistryTests.cs

@@ -1,6 +1,7 @@
 using System.ComponentModel.DataAnnotations;
 using System.Globalization;
 using Polly.Registry;
+using Polly.Telemetry;
 
 namespace Polly.Core.Tests.Registry;
 
@@ -117,6 +118,24 @@ public void AddBuilder_GetStrategy_EnsureCalled()
         strategies.Keys.Should().HaveCount(3);
     }
 
+    [Fact]
+    public void AddBuilder_EnsureStrategyKey()
+    {
+        var called = false;
+        var registry = CreateRegistry();
+        registry.TryAddBuilder(StrategyId.Create("A"), (key, builder) =>
+        {
+            builder.AddStrategy(new TestResilienceStrategy());
+            builder.Properties.TryGetValue(TelemetryUtil.StrategyKey, out var val).Should().BeTrue();
+            val.Should().Be(key.ToString());
+            called = true;
+        });
+
+        registry.Get(StrategyId.Create("A", "Instance1"));
+
+        called.Should().BeTrue();
+    }
+
     [Fact]
     public void TryGet_NoBuilder_Null()
     {

src/Polly.Core.Tests/ResilienceContextTests.cs

@@ -17,13 +17,16 @@ public void Get_EnsureDefaults()
     }
 
     [Fact]
-    public void Get_EnsurePooled()
+    public async Task Get_EnsurePooled()
     {
-        var context = ResilienceContext.Get();
+        await TestUtils.AssertWithTimeoutAsync(() =>
+        {
+            var context = ResilienceContext.Get();
 
-        ResilienceContext.Return(context);
+            ResilienceContext.Return(context);
 
-        ResilienceContext.Get().Should().BeSameAs(context);
+            ResilienceContext.Get().Should().BeSameAs(context);
+        });
     }
 
     [Fact]
@@ -33,17 +36,20 @@ public void Return_Null_Throws()
     }
 
     [Fact]
-    public void Return_EnsureDefaults()
+    public async Task Return_EnsureDefaults()
     {
-        using var cts = new CancellationTokenSource();
-        var context = ResilienceContext.Get();
-        context.CancellationToken = cts.Token;
-        context.Initialize<bool>(true);
-        context.CancellationToken.Should().Be(cts.Token);
-        context.Properties.Set(new ResiliencePropertyKey<int>("abc"), 10);
-        ResilienceContext.Return(context);
+        await TestUtils.AssertWithTimeoutAsync(() =>
+        {
+            using var cts = new CancellationTokenSource();
+            var context = ResilienceContext.Get();
+            context.CancellationToken = cts.Token;
+            context.Initialize<bool>(true);
+            context.CancellationToken.Should().Be(cts.Token);
+            context.Properties.Set(new ResiliencePropertyKey<int>("abc"), 10);
+            ResilienceContext.Return(context);
 
-        AssertDefaults(context);
+            AssertDefaults(context);
+        });
     }
 
     [InlineData(true)]

src/Polly.Core.Tests/Strategy/ResilienceStrategyTelemetryTests.cs

@@ -50,6 +50,16 @@ public void Report_NoOutcomeWhenNotSubscribed_None()
         _diagnosticSource.VerifyNoOtherCalls();
     }
 
+    [Fact]
+    public void ResilienceStrategyTelemetry_NoDiagnosticSource_Ok()
+    {
+        var source = new ResilienceTelemetrySource("builder", new ResilienceProperties(), "strategy-name", "strategy-type");
+        var sut = new ResilienceStrategyTelemetry(source, null);
+
+        sut.Invoking(s => s.Report("dummy", new TestArguments())).Should().NotThrow();
+        sut.Invoking(s => s.Report("dummy", new Outcome<int>(1), new TestArguments())).Should().NotThrow();
+    }
+
     [Fact]
     public void Report_Outcome_OK()
     {

src/Polly.Core.Tests/Telemetry/TelemetryUtilTests.cs

@@ -6,6 +6,13 @@ namespace Polly.Core.Tests.Telemetry;
 
 public class TelemetryUtilTests
 {
+    [Fact]
+    public void Ctor_Ok()
+    {
+        TelemetryUtil.DiagnosticSourceKey.Key.Should().Be("DiagnosticSource");
+        TelemetryUtil.StrategyKey.Key.Should().Be("StrategyKey");
+    }
+
     [Fact]
     public void CreateResilienceTelemetry_Ok()
     {
@@ -14,9 +21,7 @@ public void CreateResilienceTelemetry_Ok()
         telemetry.TelemetrySource.BuilderName.Should().Be("builder");
         telemetry.TelemetrySource.StrategyName.Should().Be("strategy-name");
         telemetry.TelemetrySource.StrategyType.Should().Be("strategy-type");
-        telemetry.DiagnosticSource.Should().NotBeNull();
-
-        telemetry.DiagnosticSource.Should().BeOfType<DiagnosticListener>().Subject.Name.Should().Be("Polly");
+        telemetry.DiagnosticSource.Should().BeNull();
     }
 
     [Fact]

src/Polly.Core/Polly.Core.csproj

@@ -18,6 +18,7 @@
     <Using Include="Polly.Utils" />
     <Using Remove="System.Net.Http" />
     <InternalsVisibleToTest Include="Polly.Core.Tests" />
+    <InternalsVisibleToTest Include="Polly.Extensions" />
   </ItemGroup>
 
   <ItemGroup>

src/Polly.Core/Registry/ResilienceStrategyRegistry.cs

@@ -1,4 +1,5 @@
 using System.Diagnostics.CodeAnalysis;
+using Polly.Telemetry;
 
 namespace Polly.Registry;
 
@@ -20,6 +21,7 @@ public sealed class ResilienceStrategyRegistry<TKey> : ResilienceStrategyProvide
     private readonly Func<ResilienceStrategyBuilder> _activator;
     private readonly ConcurrentDictionary<TKey, Action<TKey, ResilienceStrategyBuilder>> _builders;
     private readonly ConcurrentDictionary<TKey, ResilienceStrategy> _strategies;
+    private readonly Func<TKey, string> _keyFormatter;
 
     /// <summary>
     /// Initializes a new instance of the <see cref="ResilienceStrategyRegistry{TKey}"/> class with the default comparer.
@@ -42,6 +44,7 @@ public ResilienceStrategyRegistry(ResilienceStrategyRegistryOptions<TKey> option
         _activator = options.BuilderFactory;
         _builders = new ConcurrentDictionary<TKey, Action<TKey, ResilienceStrategyBuilder>>(options.BuilderComparer);
         _strategies = new ConcurrentDictionary<TKey, ResilienceStrategy>(options.StrategyComparer);
+        _keyFormatter = options.KeyFormatter;
     }
 
     /// <summary>
@@ -86,6 +89,7 @@ public override bool TryGet(TKey key, [NotNullWhen(true)] out ResilienceStrategy
             strategy = _strategies.GetOrAdd(key, key =>
             {
                 var builder = _activator();
+                builder.Properties.Set(TelemetryUtil.StrategyKey, _keyFormatter(key));
                 configure(key, builder);
                 return builder.Build();
             });