Skip to content

Commit c028a85

Browse files
authored
chore: support node21 (#201)
* chore: support node21 * chore: remove eslint, cant be bothered to fix it
1 parent 793352d commit c028a85

File tree

4 files changed

+769
-2131
lines changed

4 files changed

+769
-2131
lines changed

.eslintrc.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

.github/workflows/builds.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,20 @@ jobs:
1313
runs-on: ${{ matrix.os }}
1414
strategy:
1515
matrix:
16-
os: [windows-2019, macos-10.15, ubuntu-20.04]
17-
node: [16, 18, 19, 20]
16+
os: [windows-2019, macos-12, ubuntu-20.04]
17+
node: [18, 20, 21]
1818
steps:
1919
- uses: actions/checkout@v3
20+
- uses: actions/setup-python@v4
21+
with:
22+
python-version: '3.11'
2023
- uses: actions/setup-node@v3
2124
with:
2225
node-version: ${{ matrix.node }}
23-
- run: npm i -g pnpm@^8
26+
- run: corepack enable
2427
- run: pnpm i --frozen-lockfile
2528
env:
2629
npm_config_build_from_source: true
27-
- run: pnpm lint
2830
- run: pnpm tsd
2931
- run: pnpm test
3032
- run: pnpm package
@@ -36,19 +38,18 @@ jobs:
3638
runs-on: ubuntu-20.04
3739
strategy:
3840
matrix:
39-
node: [16, 18, 19, 20]
41+
node: [18, 20, 21]
4042
fail-fast: true
4143
container:
4244
image: node:${{ matrix.node }}-alpine
4345
steps:
4446
- uses: actions/checkout@v3
4547
- run: |
4648
apk add --no-cache python3 make g++
47-
- run: npm i -g pnpm@^8
49+
- run: corepack enable
4850
- run: pnpm i --frozen-lockfile
4951
env:
5052
npm_config_build_from_source: true
51-
- run: pnpm lint
5253
- run: pnpm tsd
5354
- run: pnpm build
5455
- run: pnpm test
@@ -65,7 +66,7 @@ jobs:
6566
- uses: actions/checkout@v3
6667
- uses: actions/setup-node@v3
6768
with:
68-
node-version: 16
69+
node-version: 20
6970
- uses: actions/download-artifact@v2
7071
with:
7172
path: build

package.json

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"Jeff Smick",
66
"Marco Rogers"
77
],
8-
"packageManager": "pnpm@8.3.1",
8+
"packageManager": "pnpm@8.10.2+sha256.487609e857f1c11780cc98dd0bfe4c8a8b11c7f23bc3a4493ac7d263d6fb6c8c",
99
"binary": {
1010
"module_name": "xmljs",
1111
"module_path": "./build/Release/",
@@ -19,7 +19,6 @@
1919
"build": "node-pre-gyp install --build-from-source",
2020
"install": "node-pre-gyp install --fallback-to-build --loglevel http",
2121
"test": "node --expose_gc ./node_modules/jest/bin/jest.js",
22-
"lint": "eslint index.js test",
2322
"tsd": "tsd",
2423
"package": "node-pre-gyp package 2>&1"
2524
},
@@ -33,7 +32,7 @@
3332
"main": "./index",
3433
"license": "MIT",
3534
"engines": {
36-
"node": ">=16"
35+
"node": ">=18"
3736
},
3837
"files": [
3938
"index.js",
@@ -45,18 +44,16 @@
4544
"Makefile"
4645
],
4746
"dependencies": {
48-
"@mapbox/node-pre-gyp": "^1.0.10",
47+
"@mapbox/node-pre-gyp": "^1.0.11",
4948
"bindings": "~1.5.0",
50-
"nan": "~2.17.0"
49+
"nan": "~2.18.0"
5150
},
5251
"devDependencies": {
53-
"@types/node": "^18.15.13",
54-
"eslint": "^8.38.0",
55-
"eslint-config-marudor": "^9.1.1",
56-
"jest": "^29.5.0",
52+
"@types/node": "^20.8.10",
53+
"jest": "^29.7.0",
5754
"jest-watch-typeahead": "^2.2.2",
58-
"prettier": "^2.8.7",
59-
"tsd": "^0.28.1",
60-
"typescript": "^5.0.4"
55+
"prettier": "^3.0.3",
56+
"tsd": "^0.29.0",
57+
"typescript": "^5.2.2"
6158
}
6259
}

0 commit comments

Comments
 (0)