From 2a8d13886f811812297ace97a0838225d65e8baa Mon Sep 17 00:00:00 2001 From: Antony Lee Date: Sun, 22 May 2022 19:26:54 +0200 Subject: [PATCH] Remove unused 'close' arg to show(). For reference, _Backend_ipympl.show is effectively the function that pyplot.show calls (pyplot.show even copies the signature of the backend show). In af699c2, a 'close' kwarg was added to _Backend_ipympl.show, although any use of it was immediately removed in a subsequent commit (783419b). Still, this change means that calling e.g. `plt.show(True)`, for example, would no longer set `block=True`, but instead set `close=True`. As the change is relatively recent, it seems better to remove the unused 'close' kwarg again, which also makes the signature consistent with the builtin Matplotlib backends. --- ipympl/backend_nbagg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipympl/backend_nbagg.py b/ipympl/backend_nbagg.py index e740cef8..1e99da45 100644 --- a/ipympl/backend_nbagg.py +++ b/ipympl/backend_nbagg.py @@ -498,7 +498,7 @@ def destroy(event): return manager @staticmethod - def show(close=None, block=None): + def show(block=None): # # TODO: something to do when keyword block==False ? interactive = is_interactive()