Broadcast time left should never be negative (#10070)

Author: weeman1337

src/voice-broadcast/models/VoiceBroadcastPlayback.ts

@@ -441,7 +441,9 @@ export class VoiceBroadcastPlayback
     }
 
     public get timeLeftSeconds(): number {
-        return Math.round(this.durationSeconds) - this.timeSeconds;
+        // Sometimes the meta data and the audio files are a little bit out of sync.
+        // Be sure it never returns a negative value.
+        return Math.max(0, Math.round(this.durationSeconds) - this.timeSeconds);
     }
 
     public async skipTo(timeSeconds: number): Promise<void> {

test/voice-broadcast/models/VoiceBroadcastPlayback-test.tsx

@@ -525,6 +525,20 @@ describe("VoiceBroadcastPlayback", () => {
 
                 it("should update the time", () => {
                     expect(playback.timeSeconds).toBe(11);
+                    expect(playback.timeLeftSeconds).toBe(2);
+                });
+            });
+
+            describe("and the chunk playback progresses across the actual time", () => {
+                // This can be the case if the meta data is out of sync with the actual audio data.
+
+                beforeEach(() => {
+                    chunk1Playback.clockInfo.liveData.update([15]);
+                });
+
+                it("should update the time", () => {
+                    expect(playback.timeSeconds).toBe(15);
+                    expect(playback.timeLeftSeconds).toBe(0);
                 });
             });