Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 024f121

Browse files
Fix reported bugbear: too broad exception assertion (#9753)
1 parent 0ef321f commit 024f121

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

changelog.d/9753.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Check that a `ConfigError` is raised, rather than simply `Exception`, when appropriate in homeserver config file generation tests.

tests/config/test_load.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import yaml
2222

23+
from synapse.config import ConfigError
2324
from synapse.config.homeserver import HomeServerConfig
2425

2526
from tests import unittest
@@ -35,9 +36,9 @@ def tearDown(self):
3536

3637
def test_load_fails_if_server_name_missing(self):
3738
self.generate_config_and_remove_lines_containing("server_name")
38-
with self.assertRaises(Exception):
39+
with self.assertRaises(ConfigError):
3940
HomeServerConfig.load_config("", ["-c", self.file])
40-
with self.assertRaises(Exception):
41+
with self.assertRaises(ConfigError):
4142
HomeServerConfig.load_or_generate_config("", ["-c", self.file])
4243

4344
def test_generates_and_loads_macaroon_secret_key(self):

0 commit comments

Comments
 (0)