From 8b4b0655e63981ee9c1f48b8fca738efc568758f Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Thu, 7 Apr 2022 14:47:08 +0100 Subject: [PATCH 1/2] Fix fetching public rooms over federation Broke by #12364 --- synapse/federation/transport/client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse/federation/transport/client.py b/synapse/federation/transport/client.py index d4b3cb3e98ca..66a41e45fc2d 100644 --- a/synapse/federation/transport/client.py +++ b/synapse/federation/transport/client.py @@ -509,7 +509,7 @@ async def get_public_rooms( if third_party_instance_id: args["third_party_instance_id"] = (third_party_instance_id,) if limit: - args["limit"] = [limit] + args["limit"] = [str(limit)] if since_token: args["since"] = [since_token] From d2b8b977b54026e1d8069b0405be7f1f5e371351 Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Thu, 7 Apr 2022 14:48:02 +0100 Subject: [PATCH 2/2] Newsfile --- changelog.d/12410.bugfix | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/12410.bugfix diff --git a/changelog.d/12410.bugfix b/changelog.d/12410.bugfix new file mode 100644 index 000000000000..d042425d200e --- /dev/null +++ b/changelog.d/12410.bugfix @@ -0,0 +1 @@ +Fix a spec compliance issue where requests to the `/publicRooms` federation API would specify `limit` as a string. \ No newline at end of file