Disabled Spotify local API

Author: Maximilian Krauss

Winfy.Core/CoverService.cs

@@ -53,6 +53,8 @@ public string FetchCover(string artist, string track) {
         }
 
         private string FetchSpotifyCover(string cachedFileName) {
+            return string.Empty;
+
             if (!_LocalApi.HasValidToken)
                 return string.Empty;
 

Winfy.Core/JsonPersister.cs

@@ -20,9 +20,14 @@ public JsonPersister(string path) {
 
         public T Instance {
             get {
-                return _Instance ?? (_Instance = File.Exists(Path)
-                                                     ? Serializer.DeserializeFromJson<T>(Path)
-                                                     : Activator.CreateInstance<T>());
+                try {
+                    return _Instance ?? (_Instance = File.Exists(Path)
+                                                         ? Serializer.DeserializeFromJson<T>(Path)
+                                                         : Activator.CreateInstance<T>());
+                }
+                catch {
+                    return (_Instance = Activator.CreateInstance<T>());
+                }
             }
         }
 

Winfy.Core/SpotifyLocal/SpotifyLocalApi.cs

@@ -71,7 +71,9 @@ Copyright [yyyy] [name of copyright owner]
 
         /// <summary>Initializes a new SpotifyAPI object which can be used to recieve</summary>
         public SpotifyLocalApi(ILog log, AppContracts contracts, AppSettings settings) {
-            
+
+            return;
+
             //emulate the embed code [NEEDED]
             _Client = new WebClient();
             _Client.Headers.Add("Origin", "https://embed.spotify.com");
@@ -89,6 +91,8 @@ public SpotifyLocalApi(ILog log, AppContracts contracts, AppSettings settings) {
 
         public void RenewToken() {
             try {
+                return;
+
                 //Reset fields
                 _OAuth = string.Empty;
                 _Cfid = string.Empty;
@@ -109,6 +113,8 @@ public bool HasValidToken {
         /// <param name="uri">The Spotify album URI</param>
         public string GetArt(string uri) {
             try {
+                return string.Empty;
+
                 var albumId = uri.Split(new[] {":"}, StringSplitOptions.RemoveEmptyEntries).Last();
                 var lines = _Client.DownloadString(string.Format("http://open.spotify.com/album/{0}", albumId))
                                    .Replace("\t", string.Empty)
@@ -199,6 +205,8 @@ public Status Pause {
         public Status Status {
             get {
                 try {
+                    return null;
+
                     var a = SendLocalRequest("remote/status.json", true, true, _Wait);
                     var d = (List<Status>) JsonConvert.DeserializeObject(a, typeof (List<Status>));
 

Winfy/AppWindowManager.cs

@@ -62,7 +62,7 @@ private void SetupShell(Window window) {
                                             DwmSetWindowAttribute(helper.Handle, 2, ref val, 4);
                                             var m = new Margins { bottomHeight = -1, leftWidth = -1, rightWidth = -1, topHeight = -1 };
                                             DwmExtendFrameIntoClientArea(helper.Handle, ref m);
-                                            IntPtr hwnd = new WindowInteropHelper(window).Handle;
+                                            var hwnd = new WindowInteropHelper(window).Handle;
                                         };
             window.MouseLeftButtonDown += (o, e) => window.DragMove();
 
@@ -77,22 +77,28 @@ private void TrackLocation(Window wnd, object rootViewModel) {
             var wndId = rootViewModel.GetType().Name.ToSHA1();
 
             var savedPosition = _Settings.Positions.FirstOrDefault(p => p.WindowId == wndId);
-            if (savedPosition == null) {
-                wnd.WindowStartupLocation = wnd.Owner != null
-                                                ? WindowStartupLocation.CenterOwner
-                                                : WindowStartupLocation.CenterScreen;
-            }
-            else {
+            if (savedPosition != null) {
                 wnd.WindowStartupLocation = WindowStartupLocation.Manual;
                 wnd.Top = savedPosition.Top;
                 wnd.Left = savedPosition.Left;
             }
+            else
+                wnd.WindowStartupLocation = wnd.Owner != null
+                                                ? WindowStartupLocation.CenterOwner
+                                                : WindowStartupLocation.CenterScreen;
 
             if (savedPosition == null) {
                 savedPosition = new WindowPosition {WindowId = wndId};
                 _Settings.Positions.Add(savedPosition);
             }
 
+            //Track the location of the Shell any time its changed
+            if (rootViewModel is ShellViewModel)
+                wnd.LocationChanged += (o, e) => {
+                                           savedPosition.Top = ((Window) o).Top;
+                                           savedPosition.Left = ((Window) o).Left;
+                                       };
+
             wnd.Closing += (o, e) => {
                                savedPosition.Top = ((Window) o).Top;
                                savedPosition.Left = ((Window) o).Left;

Winfy/Views/ShellView.xaml

@@ -65,7 +65,7 @@
                 <MenuItem Header="About Winfy..." cal:Message.Attach="[Event Click] = [Action ShowAbout]" />
                 <MenuItem Header="Settings..." cal:Message.Attach="[Event Click] = [Action ShowSettings]" />
                 <Separator/>
-                <MenuItem Header="Play/Pause" cal:Message.Attach="[Event Click] = [Action PlayPause]" />
+                <MenuItem Header="Toggle playback" cal:Message.Attach="[Event Click] = [Action PlayPause]" />
                 <MenuItem Header="Previous track" cal:Message.Attach="[Event Click] = [Action PlayPrevious]" />
                 <MenuItem Header="Next track" cal:Message.Attach="[Event Click] = [Action PlayNext]" />
                 <Separator/>
@@ -109,7 +109,7 @@
                                                   ImageSourceNormal="/Images/Player/play-pause-normal.png"
                                                   ImageSource="/Images/Player/play-pause-normal.png"
                                                   ImageSourcePressed="/Images/Player/play-pause-pressed.png"
-                                                  ToolTip="play/pause"/>
+                                                  ToolTip="Toggle playback"/>
                                 <ctrl:ImageButton Width="24" Height="25" x:Name="PlayNext"
                                                   ImageSourceNormal="/Images/Player/next-normal.png"
                                                   ImageSource="/Images/Player/next-normal.png"

Winfy/changelog.json

@@ -1,4 +1,12 @@
 [
+	{
+		"version": "2.0.1.5",
+		"description": "bugfix",
+		"changes": [
+			"Fixed: Corrupt settings file could crash whole app",
+			"Important: Looks like Spotify killed the Local-Api. I had to disable the interaction with the Spotify client which causes some lags in determining the current cover image."
+		]
+	},
 	{
 		"version": "2.0.1.4",
 		"description": "buttons!",