chore: update minimum go version to 1.25 (#239)

Author: mccutchen

Dockerfile

@@ -1,5 +1,5 @@
 # syntax = docker/dockerfile:1.3
-FROM golang:1.23 AS build
+FROM golang:1.26 AS build
 
 WORKDIR /go/src/github.com/mccutchen/go-httpbin
 

examples/custom-instrumentation/go.mod

@@ -1,18 +1,18 @@
 module httpbin-instrumentation
 
-go 1.22.0
+go 1.25.0
 
 require (
 	github.com/DataDog/datadog-go v4.8.3+incompatible
-	github.com/mccutchen/go-httpbin/v2 v2.14.1
+	github.com/mccutchen/go-httpbin/v2 v2.20.0
 )
 
 require (
 	github.com/Microsoft/go-winio v0.6.2 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/stretchr/objx v0.3.0 // indirect
 	github.com/stretchr/testify v1.3.0 // indirect
-	golang.org/x/sys v0.25.0 // indirect
+	golang.org/x/sys v0.41.0 // indirect
 )
 
 // Always build against the local version, to make it easier to update examples

examples/custom-instrumentation/go.sum

@@ -14,3 +14,5 @@ github.com/stretchr/testify v1.3.0 h1:TivCn/peBQ7UY8ooIcPgZFpTNSz0Q2U6UrFlUfqbe0
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
 golang.org/x/sys v0.25.0 h1:r+8e+loiHxRqhXVl6ML1nO3l1+oFoWbnlu2Ehimmi34=
 golang.org/x/sys v0.25.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
+golang.org/x/sys v0.41.0 h1:Ivj+2Cp/ylzLiEU89QhWblYnOE9zerudt9Ftecq2C6k=
+golang.org/x/sys v0.41.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=

go.mod

@@ -1,3 +1,3 @@
 module github.com/mccutchen/go-httpbin/v2
 
-go 1.22.0
+go 1.25.0

httpbin/cmd/cmd.go

@@ -287,7 +287,7 @@ func loadConfig(args []string, getEnvVal func(string) string, getEnviron func()
 	if cfg.rawAllowedRedirectDomains == "" && getEnvVal("ALLOWED_REDIRECT_DOMAINS") != "" {
 		cfg.rawAllowedRedirectDomains = getEnvVal("ALLOWED_REDIRECT_DOMAINS")
 	}
-	for _, domain := range strings.Split(cfg.rawAllowedRedirectDomains, ",") {
+	for domain := range strings.SplitSeq(cfg.rawAllowedRedirectDomains, ",") {
 		if strings.TrimSpace(domain) != "" {
 			cfg.AllowedRedirectDomains = append(cfg.AllowedRedirectDomains, strings.TrimSpace(domain))
 		}

httpbin/cmd/cmd_test.go

@@ -703,7 +703,7 @@ func mergedConfig(base, override *config) *config {
 			if overrideField.Bool() {
 				resultField.SetBool(overrideField.Bool())
 			}
-		case reflect.Ptr:
+		case reflect.Pointer:
 			if !overrideField.IsNil() {
 				resultField.Set(overrideField)
 			}

httpbin/handlers.go

@@ -984,7 +984,7 @@ func (h *HTTPBin) handleBytes(w http.ResponseWriter, r *http.Request, streaming
 	w.WriteHeader(http.StatusOK)
 
 	var chunk []byte
-	for i := 0; i < numBytes; i++ {
+	for range numBytes {
 		chunk = append(chunk, byte(rng.Intn(256)))
 		if len(chunk) == chunkSize {
 			write(chunk)

httpbin/handlers_test.go

@@ -1420,10 +1420,8 @@ func TestRedirects(t *testing.T) {
 	}
 
 	for _, prefix := range []string{"", "/test-prefix"} {
-		prefix := prefix
 		app := setupTestApp(t, WithPrefix(prefix))
 		for _, test := range tests {
-			test := test
 			reqPath := fmt.Sprintf(test.requestURL, prefix)
 			t.Run("ok"+reqPath, func(t *testing.T) {
 				t.Parallel()
@@ -1465,10 +1463,8 @@ func TestRedirects(t *testing.T) {
 	}
 
 	for _, prefix := range []string{"", "/test-prefix"} {
-		prefix := prefix
 		app := setupTestApp(t, WithPrefix(prefix))
 		for _, test := range errorTests {
-			test := test
 			reqPath := fmt.Sprintf(test.requestURL, prefix)
 			t.Run("error"+reqPath, func(t *testing.T) {
 				t.Parallel()
@@ -2914,7 +2910,6 @@ func TestStreamBytes(t *testing.T) {
 
 func TestLinks(t *testing.T) {
 	for _, prefix := range []string{"", "/test-prefix"} {
-		prefix := prefix
 		app := setupTestApp(t, WithPrefix(prefix))
 
 		redirectTests := []struct {

httpbin/helpers_test.go

@@ -672,9 +672,9 @@ func decodeServerTimings(headerVal string) map[string]serverTiming {
 		return nil
 	}
 	timings := map[string]serverTiming{}
-	for _, entry := range strings.Split(headerVal, ",") {
+	for entry := range strings.SplitSeq(headerVal, ",") {
 		var t serverTiming
-		for _, kv := range strings.Split(entry, ";") {
+		for kv := range strings.SplitSeq(entry, ";") {
 			kv = strings.TrimSpace(kv)
 			key, val, _ := strings.Cut(kv, "=")
 			switch key {