ensure array access is not out of bounds

ewu63 · ewu63 · commit 57c6256f403d · 2025-04-20T12:37:04.000-07:00
diff --git a/pyoptsparse/pyNSGA2/source/tourselect.c b/pyoptsparse/pyNSGA2/source/tourselect.c
@@ -32,7 +32,7 @@ void selection (population *old_pop, population *new_pop, Global global, int *nr
         a2[rand] = a2[i];
         a2[i] = temp;
     }
-    for (i=0; i<global.popsize; i+=4)
+    for (i=0; i<global.popsize-4; i+=4)
     {
         parent1 = tournament (&old_pop->ind[a1[i]], &old_pop->ind[a1[i+1]], global);
         parent2 = tournament (&old_pop->ind[a1[i+2]], &old_pop->ind[a1[i+3]], global);

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ void selection (population old_pop, population new_pop, Global global, int *nr`
`32`	`32`	`a2[rand] = a2[i];`
`33`	`33`	`a2[i] = temp;`
`34`	`34`	`}`
`35`		`- for (i=0; i<global.popsize; i+=4)`
	`35`	`+ for (i=0; i<global.popsize-4; i+=4)`
`36`	`36`	`{`
`37`	`37`	`parent1 = tournament (&old_pop->ind[a1[i]], &old_pop->ind[a1[i+1]], global);`
`38`	`38`	`parent2 = tournament (&old_pop->ind[a1[i+2]], &old_pop->ind[a1[i+3]], global);`