Skip to content

Commit 4f97836

Browse files
committed
WIP: More type check fixes
1 parent 59aa8ab commit 4f97836

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

medkit/core/operation.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,22 +34,15 @@ class Operation(abc.ABC):
3434
>>> super().__init__(**init_args)
3535
"""
3636

37-
uid: str
38-
_description: OperationDescription | None = None
3937
_prov_tracer: ProvTracer | None = None
4038

4139
@abc.abstractmethod
4240
def __init__(self, uid: str | None = None, name: str | None = None, **kwargs):
43-
if uid is None:
44-
uid = generate_id()
45-
if name is None:
46-
name = self.__class__.__name__
47-
48-
self.uid = uid
41+
self.uid = uid or generate_id()
4942
self._description = OperationDescription(
5043
uid=self.uid,
5144
class_name=self.__class__.__name__,
52-
name=name,
45+
name=name or self.__class__.__name__,
5346
config=kwargs,
5447
)
5548

@@ -68,9 +61,9 @@ def description(self) -> OperationDescription:
6861
"""Contains all the operation init parameters."""
6962
return self._description
7063

71-
def check_sanity(self) -> bool: # noqa: B027
64+
def check_sanity(self) -> None:
7265
# TODO: add some checks
73-
pass
66+
return
7467

7568

7669
class DocOperation(Operation):

0 commit comments

Comments
 (0)