Contribution question: TypeModel

[AdmiralSnyder]

Hello,
would splitting up the TypeModel.cs file into different files and moving them into a Models folder be a contribution you'd accept?

[mganss]

You mean creating a separate file for each class that's currently in TypeModel.cs? Sure, go ahead.

[AdmiralSnyder]

i just PRed #576 :-)

also, @mganss, could you maybe have a look at the issue #561 - maybe there is an easier solution than me creating additional partial files in a second run over the .xsd files...

thank you, have a great day

[mganss]

What do you mean by creating additional partial files?
You'll probably have to flesh out the enum restriction handling for complex type here:

XmlSchemaClassGenerator/XmlSchemaClassGenerator/ModelBuilder.cs

Line 516 in d974d57

private TypeModel CreateTypeModel(XmlSchemaComplexType complexType)

[AdmiralSnyder]

Hey, i looked into modifying the ModelBuilder but that approach doesn't seem convenient, since i'd have to move lots of info between the different layers of intermediate types to output the things i want.

in my case, i cannot just turn it into a c# enum and call it a day, since the type needs to inherit from a certain base type to allow for application of the value. So i add another partial class where i put the differnet possible values from the restrictions enumeration as static readonly fields, so i can at least refer to the different values in the consuming code via defined names.

[mganss]

I've tried letting Copilot fix #561, see #578 and it looks good, but I haven't had the time to check it more thoroughly. There are intermittent test failures but I think they are unrelated to the PR but rather related to threading issues in the tests exposed by changes in the test runner.