AdSense/Doubleclick Launch Adx/Ady Rounding (ampproject#29737)

* Launch AdSense/Doubleclick Round Positions Experiment

* linter fixes

Author: keithwrightbos

build-system/global-configs/canary-config.json

@@ -37,6 +37,6 @@
   "amp-ad-no-center-css": 0,
   "sticky-ad-padding-bottom": 1,
   "analytics-chunks": 1,
-  "ad-adsense-gam-round-params": 0.2,
+  "ad-adsense-gam-round-params": 0.1,
   "render-on-idle-fix": 1
 }

build-system/global-configs/prod-config.json

@@ -38,5 +38,5 @@
   "analytics-chunks": 1,
   "sticky-ad-padding-bottom": 1,
   "render-on-idle-fix": 1,
-  "ad-adsense-gam-round-params": 0.2
+  "ad-adsense-gam-round-params": 0.1
 }

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js

@@ -70,10 +70,10 @@ const ADSENSE_BASE_URL = 'https://googleads.g.doubleclick.net/pagead/ads';
 const TAG = 'amp-ad-network-adsense-impl';
 
 /** @const @enum {string} */
-const ROUND_LOCATION_PARAMS_EXP = {
+const ROUND_LOCATION_PARAMS_HOLDBACK_EXP = {
   ID: 'ad-adsense-gam-round-params',
-  CONTROL: '21066726',
-  EXPERIMENT: '21066727',
+  CONTROL: '21067039',
+  EXPERIMENT: '21067040',
 };
 
 /**
@@ -253,11 +253,11 @@ export class AmpAdNetworkAdsenseImpl extends AmpA4A {
         ],
       },
       {
-        experimentId: ROUND_LOCATION_PARAMS_EXP.ID,
+        experimentId: ROUND_LOCATION_PARAMS_HOLDBACK_EXP.ID,
         isTrafficEligible: () => true,
         branches: [
-          ROUND_LOCATION_PARAMS_EXP.CONTROL,
-          ROUND_LOCATION_PARAMS_EXP.EXPERIMENT,
+          ROUND_LOCATION_PARAMS_HOLDBACK_EXP.CONTROL,
+          ROUND_LOCATION_PARAMS_HOLDBACK_EXP.EXPERIMENT,
         ],
       },
     ]).concat(AMPDOC_FIE_EXPERIMENT_INFO_LIST);
@@ -424,7 +424,10 @@ export class AmpAdNetworkAdsenseImpl extends AmpA4A {
           'pucrd': identity.pucrd || null,
           ...parameters,
         },
-        isInExperiment(this.element, ROUND_LOCATION_PARAMS_EXP.EXPERIMENT),
+        !isInExperiment(
+          this.element,
+          ROUND_LOCATION_PARAMS_HOLDBACK_EXP.EXPERIMENT
+        ),
         experimentIds
       );
     });

extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js

@@ -160,10 +160,10 @@ export const EXPAND_JSON_TARGETING_EXP = {
 };
 
 /** @const @enum {string} */
-const ROUND_LOCATION_PARAMS_EXP = {
+const ROUND_LOCATION_PARAMS_HOLDBACK_EXP = {
   ID: 'ad-adsense-gam-round-params',
-  CONTROL: '21066728',
-  EXPERIMENT: '21066729',
+  CONTROL: '21067041',
+  EXPERIMENT: '21067042',
 };
 
 /**
@@ -479,11 +479,11 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
         ],
       },
       {
-        experimentId: ROUND_LOCATION_PARAMS_EXP.ID,
+        experimentId: ROUND_LOCATION_PARAMS_HOLDBACK_EXP.ID,
         isTrafficEligible: () => true,
         branches: [
-          ROUND_LOCATION_PARAMS_EXP.CONTROL,
-          ROUND_LOCATION_PARAMS_EXP.EXPERIMENT,
+          ROUND_LOCATION_PARAMS_HOLDBACK_EXP.CONTROL,
+          ROUND_LOCATION_PARAMS_HOLDBACK_EXP.EXPERIMENT,
         ],
       },
     ]).concat(AMPDOC_FIE_EXPERIMENT_INFO_LIST);
@@ -682,7 +682,9 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
         : null,
       ...googleBlockParameters(
         this,
-        this.experimentIds.includes(ROUND_LOCATION_PARAMS_EXP.EXPERIMENT)
+        !this.experimentIds.includes(
+          ROUND_LOCATION_PARAMS_HOLDBACK_EXP.EXPERIMENT
+        )
       ),
     };
   }
@@ -797,7 +799,9 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
           this.getPageParameters(consentTuple, /* instances= */ undefined),
           rtcParams
         ),
-        this.experimentIds.includes(ROUND_LOCATION_PARAMS_EXP.EXPERIMENT),
+        !this.experimentIds.includes(
+          ROUND_LOCATION_PARAMS_HOLDBACK_EXP.EXPERIMENT
+        ),
         this.experimentIds
       ).then((adUrl) => this.getAdUrlDeferred.resolve(adUrl));
     });
@@ -2013,8 +2017,8 @@ function constructSRARequest_(a4a, instances) {
       googlePageParameters(
         a4a,
         startTime,
-        instances[0].experimentIds.includes(
-          ROUND_LOCATION_PARAMS_EXP.EXPERIMENT
+        !instances[0].experimentIds.includes(
+          ROUND_LOCATION_PARAMS_HOLDBACK_EXP.EXPERIMENT
         )
       )
     )