fix: raise on error (#712)

* fix: remember raise for until_executing

* chore: mandatory rubocop commit

* chore: mandatory linter commit

Author: mhenrixon

.reek.yml

@@ -143,6 +143,7 @@ detectors:
       - SidekiqUniqueJobs::Lock#lock
       - SidekiqUniqueJobs::Lock::BaseLock#call_strategy
       - SidekiqUniqueJobs::Lock::UntilAndWhileExecuting#execute
+      - SidekiqUniqueJobs::Lock::UntilExecuting#execute
       - SidekiqUniqueJobs::Lock::WhileExecuting#execute
       - SidekiqUniqueJobs::LockArgs#filtered_args
       - SidekiqUniqueJobs::LockInfo#set

lib/sidekiq_unique_jobs/lock/until_executing.rb

@@ -36,6 +36,7 @@ def execute
       rescue StandardError => ex
         reflect(:execution_failed, item, ex)
         locksmith.lock(wait: 1)
+        raise
       end
     end
   end

spec/sidekiq_unique_jobs/lock/until_executing_spec.rb

@@ -47,16 +47,15 @@
 
       it "locks the job again" do
         process_one.lock
-        process_one.execute(&block)
+        expect { process_one.execute(&block) }.to raise_error(RuntimeError, "Hell")
         expect(process_one).to be_locked
       end
 
       it "reflects execution failed" do
         allow(process_one).to receive(:reflect)
 
         process_one.lock
-        process_one.execute(&block)
-
+        expect { process_one.execute(&block) }.to raise_error(RuntimeError, "Hell")
         expect(process_one).to have_received(:reflect)
           .with(:execution_failed, item_one, kind_of(RuntimeError))
       end

spec/sidekiq_unique_jobs/unlockable_spec.rb

@@ -45,7 +45,7 @@
 
     specify do
       expect { push_item(item) }.to change { unique_keys.size }.by(3)
-      expect { delete }.to change { unique_keys.size }.by(0)
+      expect { delete }.not_to change { unique_keys.size }
     end
   end