From 1ee8e7cff956cf39b4c3b700685a20f4a68709d5 Mon Sep 17 00:00:00 2001
From: Robert Knight <robert@microbit.org>
Date: Thu, 4 Apr 2024 14:44:39 +0100
Subject: [PATCH] Fix serial re-init required when switching tabs

This moves the ref for the parent container into the useEffect call
instead of copying it outside of the useEffect.
---
 src/serial/XTerm.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/serial/XTerm.tsx b/src/serial/XTerm.tsx
index 269ee0b2c..166c78281 100644
--- a/src/serial/XTerm.tsx
+++ b/src/serial/XTerm.tsx
@@ -47,7 +47,6 @@ const useManagedTermimal = (
   tabOutRef: HTMLElement,
   fontSizePt: number
 ): void => {
-  const parent = ref.current;
   const actionFeedback = useActionFeedback();
   const codeFontFamily = useToken("fonts", "code");
   const device = useDevice();
@@ -58,6 +57,7 @@ const useManagedTermimal = (
   const initialFontSizeRef = useRef<number>(fontSizePt);
 
   useEffect(() => {
+    const parent = ref.current;
     if (!parent) {
       return;
     }
@@ -188,11 +188,11 @@ const useManagedTermimal = (
     currentTerminalRef,
     device,
     isUnmounted,
-    parent,
     setSelection,
     fitAddon,
     initialFontSizeRef,
     tabOutRef,
+    ref,
   ]);
 
   useEffect(() => {