From cd6743dd48bf6d636ef22d9928606ee8bcedc997 Mon Sep 17 00:00:00 2001 From: CanHua Li Date: Thu, 30 Sep 2021 16:11:26 -0700 Subject: [PATCH] var to let --- source/nodejs/ac-typed-schema/src/SchemaClass.ts | 2 +- .../ac-typed-schema/src/markdown/build-model.ts | 6 +++--- .../src/markdown/generate-markdown.ts | 8 ++++---- .../nodejs/ac-typed-schema/src/markdown/style.ts | 2 +- .../nodejs/ac-typed-schema/src/typed-schema.ts | 8 ++++---- .../adaptivecards-controls/src/calendar.ts | 6 +++--- .../adaptivecards-controls/src/dropdown.ts | 4 ++-- .../adaptivecards-controls/src/popupmenu.ts | 2 +- .../src/card-designer-surface.ts | 14 +++++++------- .../adaptivecards-designer/src/card-designer.ts | 2 +- .../src/containers/outlook/outlook-container.ts | 4 ++-- .../adaptivecards-designer/src/designer-peers.ts | 16 ++++++++-------- .../nodejs/adaptivecards-visualizer/src/app.ts | 6 +++--- .../src/containers/outlook.ts | 4 ++-- .../adaptivecards/src/controls/popup-menu.ts | 2 +- 15 files changed, 43 insertions(+), 43 deletions(-) diff --git a/source/nodejs/ac-typed-schema/src/SchemaClass.ts b/source/nodejs/ac-typed-schema/src/SchemaClass.ts index 69b2919526..fc63852e92 100644 --- a/source/nodejs/ac-typed-schema/src/SchemaClass.ts +++ b/source/nodejs/ac-typed-schema/src/SchemaClass.ts @@ -14,7 +14,7 @@ export class SchemaClass extends SchemaType { super(sourceObj); if (sourceObj.properties) { - for (var key in sourceObj.properties) { + for (let key in sourceObj.properties) { this._properties.set(key, new SchemaProperty(key, sourceObj.properties[key])); } } diff --git a/source/nodejs/ac-typed-schema/src/markdown/build-model.ts b/source/nodejs/ac-typed-schema/src/markdown/build-model.ts index 30c35b5ffd..ef291d4df7 100644 --- a/source/nodejs/ac-typed-schema/src/markdown/build-model.ts +++ b/source/nodejs/ac-typed-schema/src/markdown/build-model.ts @@ -27,7 +27,7 @@ export function buildModel(options: BuildModelOptions) { var schema: Schema = Schema.fromFolder(schemaFolder); - for (var index in toc) { + for (let index in toc) { var rootObj = toc[index]; var root = { @@ -36,7 +36,7 @@ export function buildModel(options: BuildModelOptions) { schema: schema }; - for (var definitionIndex in rootObj[root.title]) { + for (let definitionIndex in rootObj[root.title]) { var name = rootObj[root.title][definitionIndex]; var objSchema = schema.getType(name); @@ -86,6 +86,6 @@ export function buildModel(options: BuildModelOptions) { } function getObjectName(obj) { - for (var property in obj) + for (let property in obj) return property; } diff --git a/source/nodejs/ac-typed-schema/src/markdown/generate-markdown.ts b/source/nodejs/ac-typed-schema/src/markdown/generate-markdown.ts index 5913e3c8af..4efa22765e 100644 --- a/source/nodejs/ac-typed-schema/src/markdown/generate-markdown.ts +++ b/source/nodejs/ac-typed-schema/src/markdown/generate-markdown.ts @@ -160,14 +160,14 @@ function createTable(formattedProperties: any[]) { */ var tableData = []; var headerRow = []; - for (var propName in formattedProperties[0]) { + for (let propName in formattedProperties[0]) { headerRow.push(__(propName)); } tableData.push(headerRow); formattedProperties.forEach((formattedProperty) => { var dataRow = []; - for (var propName in formattedProperty) { + for (let propName in formattedProperty) { dataRow.push(formattedProperty[propName]); } tableData.push(dataRow); @@ -222,14 +222,14 @@ export function createEnumSummary(enumType: SchemaEnum) { */ var tableData = []; var headerRow = []; - for (var propName in rows[0]) { + for (let propName in rows[0]) { headerRow.push(propName); } tableData.push(headerRow); rows.forEach((row) => { var dataRow = []; - for (var propName in row) { + for (let propName in row) { dataRow.push(row[propName]); } tableData.push(dataRow); diff --git a/source/nodejs/ac-typed-schema/src/markdown/style.ts b/source/nodejs/ac-typed-schema/src/markdown/style.ts index 0ffa0da3ea..0585cc0fc8 100644 --- a/source/nodejs/ac-typed-schema/src/markdown/style.ts +++ b/source/nodejs/ac-typed-schema/src/markdown/style.ts @@ -48,7 +48,7 @@ export function getHeaderMarkdown(content, level) { level = defaultValueHelper(level, 2); var md = ''; - for (var i = 0; i < level; ++i) { + for (let i = 0; i < level; ++i) { md += '#'; } diff --git a/source/nodejs/ac-typed-schema/src/typed-schema.ts b/source/nodejs/ac-typed-schema/src/typed-schema.ts index 59a06071b1..c60a474f49 100644 --- a/source/nodejs/ac-typed-schema/src/typed-schema.ts +++ b/source/nodejs/ac-typed-schema/src/typed-schema.ts @@ -37,7 +37,7 @@ function isObjectEmpty(obj: any) { if (!obj) { return true; } - for (var key in obj) { + for (let key in obj) { return false; } return true; @@ -114,7 +114,7 @@ class Transformer { } if (!isObjectEmpty(this._implementationsOf)) { - for (var key in this._implementationsOf) { + for (let key in this._implementationsOf) { var anyOfValue = []; @@ -136,7 +136,7 @@ class Transformer { } if (!isObjectEmpty(this._extendables)) { - for (var key in this._extendables) { + for (let key in this._extendables) { answer.definitions["Extendable." + key] = this._extendables[key]; } } @@ -358,7 +358,7 @@ class Transformer { private toCaseInsensitiveRegex(enumValue: string) { var answer = ""; - for (var i = 0; i < enumValue.length; i++) { + for (let i = 0; i < enumValue.length; i++) { var c = enumValue.charAt(i); answer += `[${c.toLowerCase()}|${c.toUpperCase()}]`; } diff --git a/source/nodejs/adaptivecards-controls/src/calendar.ts b/source/nodejs/adaptivecards-controls/src/calendar.ts index 0a62d600b7..d149f5fec9 100644 --- a/source/nodejs/adaptivecards-controls/src/calendar.ts +++ b/source/nodejs/adaptivecards-controls/src/calendar.ts @@ -147,7 +147,7 @@ export class Calendar extends InputControl { private initializeSelection() { if (this._date) { - for (var i = 0; i < this._days.length; i++) { + for (let i = 0; i < this._days.length; i++) { if (Utils.areDatesEqual(this._days[i].date, this.date)) { this.selectedDayCell = this._days[i]; @@ -173,7 +173,7 @@ export class Calendar extends InputControl { var dayIndex = Utils.CalendarSettings.firstDayOfWeek; - for (var i = 0; i < Utils.CalendarSettings.daysInWeek; i++) { + for (let i = 0; i < Utils.CalendarSettings.daysInWeek; i++) { var cell = document.createElement("td"); cell.className = "ms-ctrl ms-ctrl-calendarDayHeader"; cell.innerText = Utils.CalendarSettings.getInitialDayName(dayIndex); @@ -189,7 +189,7 @@ export class Calendar extends InputControl { this._miniCalendarElement.appendChild(row); - for (var i = 0; i < this._days.length; i++) { + for (let i = 0; i < this._days.length; i++) { if (i % 7 == 0) { row = document.createElement("tr"); this._miniCalendarElement.appendChild(row); diff --git a/source/nodejs/adaptivecards-controls/src/dropdown.ts b/source/nodejs/adaptivecards-controls/src/dropdown.ts index 6277e09c5f..18c18d61ab 100644 --- a/source/nodejs/adaptivecards-controls/src/dropdown.ts +++ b/source/nodejs/adaptivecards-controls/src/dropdown.ts @@ -77,7 +77,7 @@ export class DropDownPopupControl extends PopupControl { var selectedIndex = this._owner.selectedIndex; - for (var i = 0; i < this._owner.items.length; i++) { + for (let i = 0; i < this._owner.items.length; i++) { var renderedItem = this._owner.items.get(i).render(); renderedItem.tabIndex = 0; @@ -212,7 +212,7 @@ export class DropDown extends InputWithPopup attach(rootElement: HTMLElement) { super.attach(rootElement); - for (var i = 0; i < this.rootElement.children.length; i++) { + for (let i = 0; i < this.rootElement.children.length; i++) { var childElement = this.rootElement.children[i]; if (childElement.tagName.toLowerCase() == "ms-dropdown-item") { diff --git a/source/nodejs/adaptivecards-controls/src/popupmenu.ts b/source/nodejs/adaptivecards-controls/src/popupmenu.ts index e2a2382569..4eef2b54eb 100644 --- a/source/nodejs/adaptivecards-controls/src/popupmenu.ts +++ b/source/nodejs/adaptivecards-controls/src/popupmenu.ts @@ -19,7 +19,7 @@ export class PopupMenu extends PopupControl { element.className = "ms-ctrl ms-popup"; element.setAttribute("role", "listbox"); - for (var i = 0; i < this._items.length; i++) { + for (let i = 0; i < this._items.length; i++) { var renderedItem = this._items.get(i).render(); renderedItem.tabIndex = 0; diff --git a/source/nodejs/adaptivecards-designer/src/card-designer-surface.ts b/source/nodejs/adaptivecards-designer/src/card-designer-surface.ts index 35f7260708..ae07e22fb9 100644 --- a/source/nodejs/adaptivecards-designer/src/card-designer-surface.ts +++ b/source/nodejs/adaptivecards-designer/src/card-designer-surface.ts @@ -60,7 +60,7 @@ export abstract class DesignerPeerRegistry { } findTypeRegistration(sourceType: TSource): DesignerPeers.DesignerPeerRegistration { - for (var i = 0; i < this._items.length; i++) { + for (let i = 0; i < this._items.length; i++) { if (this._items[i].sourceType === sourceType) { return this._items[i]; } @@ -87,7 +87,7 @@ export abstract class DesignerPeerRegistry { } unregisterPeer(sourceType: TSource) { - for (var i = 0; i < this._items.length; i++) { + for (let i = 0; i < this._items.length; i++) { if (this._items[i].sourceType === sourceType) { this._items.splice(i, 1); @@ -372,7 +372,7 @@ export class CardDesignerSurface { peer.addElementsToDesignerSurface(this._designerSurface); - for (var i = 0; i < peer.getChildCount(); i++) { + for (let i = 0; i < peer.getChildCount(); i++) { this.addPeer(peer.getChildAt(i)); } } @@ -399,7 +399,7 @@ export class CardDesignerSurface { result = currentPeer; } - for (var i = 0; i < currentPeer.getChildCount(); i++) { + for (let i = 0; i < currentPeer.getChildCount(); i++) { var deeperResult = this.internalFindDropTarget(pointerPosition, currentPeer.getChildAt(i), forPeer); if (deeperResult) { @@ -414,7 +414,7 @@ export class CardDesignerSurface { } private findCardElementPeer(cardElement: Adaptive.CardElement): DesignerPeers.CardElementPeer { - for (var i = 0; i < this._allPeers.length; i++) { + for (let i = 0; i < this._allPeers.length; i++) { var peer = this._allPeers[i]; if (peer instanceof DesignerPeers.CardElementPeer && peer.cardElement == cardElement) { @@ -426,7 +426,7 @@ export class CardDesignerSurface { } private findActionPeer(action: Adaptive.Action): DesignerPeers.ActionPeer { - for (var i = 0; i < this._allPeers.length; i++) { + for (let i = 0; i < this._allPeers.length; i++) { var peer = this._allPeers[i]; if (peer instanceof DesignerPeers.ActionPeer && peer.action == action) { @@ -730,7 +730,7 @@ export class CardDesignerSurface { updateLayout(isFullRefresh: boolean = true) { if (!this.isPreviewMode) { - for (var i = 0; i < this._allPeers.length; i++) { + for (let i = 0; i < this._allPeers.length; i++) { this._allPeers[i].updateLayout(); } diff --git a/source/nodejs/adaptivecards-designer/src/card-designer.ts b/source/nodejs/adaptivecards-designer/src/card-designer.ts index cca9e22da7..65d7eb6308 100644 --- a/source/nodejs/adaptivecards-designer/src/card-designer.ts +++ b/source/nodejs/adaptivecards-designer/src/card-designer.ts @@ -249,7 +249,7 @@ export class CardDesigner extends Designer.DesignContext { let paletteItemContainer = document.createElement('div'); paletteItemContainer.className = "acd-palette-item-container"; - for (var i = 0; i < categorizedTypes[category].length; i++) { + for (let i = 0; i < categorizedTypes[category].length; i++) { this.addPaletteItem(categorizedTypes[category][i], paletteItemContainer); } diff --git a/source/nodejs/adaptivecards-designer/src/containers/outlook/outlook-container.ts b/source/nodejs/adaptivecards-designer/src/containers/outlook/outlook-container.ts index fde06988c7..29b6e3b232 100644 --- a/source/nodejs/adaptivecards-designer/src/containers/outlook/outlook-container.ts +++ b/source/nodejs/adaptivecards-designer/src/containers/outlook/outlook-container.ts @@ -60,7 +60,7 @@ export class OutlookContainer extends HostContainer { if (typeof source["resources"] === "object") { var actionResources = source["resources"]["actions"] as Array; - for (var i = 0; i < actionResources.length; i++) { + for (let i = 0; i < actionResources.length; i++) { let action = this.actionsRegistry.createInstance(actionResources[i]["type"], context.targetVersion); if (action) { @@ -105,7 +105,7 @@ export class OutlookContainer extends HostContainer { if (rootCard) { var actionArray = rootCard["resources"]["actions"] as Array; - for (var i = 0; i < actionArray.length; i++) { + for (let i = 0; i < actionArray.length; i++) { if (actionArray[i].id == actionId) { actionArray[i].execute(); diff --git a/source/nodejs/adaptivecards-designer/src/designer-peers.ts b/source/nodejs/adaptivecards-designer/src/designer-peers.ts index f3ffab121f..b7b724d023 100644 --- a/source/nodejs/adaptivecards-designer/src/designer-peers.ts +++ b/source/nodejs/adaptivecards-designer/src/designer-peers.ts @@ -705,7 +705,7 @@ export class ActionPropertyEditor extends SingleInputPropertyEditor { input.placeholder = "(not set)"; input.choices.push(new Adaptive.Choice("(not set)", "none")); - for (var i = 0; i < context.designContext.hostContainer.actionsRegistry.getItemCount(); i++) { + for (let i = 0; i < context.designContext.hostContainer.actionsRegistry.getItemCount(); i++) { let actionType = context.designContext.hostContainer.actionsRegistry.getItemAt(i).typeName; let excludeAction = true; @@ -1274,7 +1274,7 @@ export abstract class DesignerPeer extends DraggableElement { designerSurface.appendChild(this.renderedElement); if (processChildren) { - for (var i = 0; i < this.getChildCount(); i++) { + for (let i = 0; i < this.getChildCount(); i++) { this.getChildAt(i).addElementsToDesignerSurface(designerSurface, processChildren); } } @@ -1284,7 +1284,7 @@ export abstract class DesignerPeer extends DraggableElement { this.renderedElement.parentNode.removeChild(this.renderedElement); if (processChildren) { - for (var i = 0; i < this.getChildCount(); i++) { + for (let i = 0; i < this.getChildCount(); i++) { this.getChildAt(i).removeElementsFromDesignerSurface(processChildren); } } @@ -1683,7 +1683,7 @@ export class CardElementPeer extends DesignerPeer { } if (this.cardElement instanceof Adaptive.CardElementContainer) { - for (var i = 0; i < this.cardElement.getItemCount(); i++) { + for (let i = 0; i < this.cardElement.getItemCount(); i++) { let existingPeer = this.findCardElementChild(this.cardElement.getItemAt(i)); if (!existingPeer) { @@ -1698,7 +1698,7 @@ export class CardElementPeer extends DesignerPeer { } } - for (var i = 0; i < this.cardElement.getActionCount(); i++) { + for (let i = 0; i < this.cardElement.getActionCount(); i++) { let existingPeer = this.findActionChild(this.cardElement.getActionAt(i)); if (!existingPeer) { @@ -1744,7 +1744,7 @@ export class CardElementPeer extends DesignerPeer { let targetChild: DesignerPeer = null; let insertAfter: boolean; - for (var i = 0; i < this.getChildCount(); i++) { + for (let i = 0; i < this.getChildCount(); i++) { let rect = this.getChildAt(i).getBoundingRect(); if (rect.isInside(insertionPoint)) { @@ -1922,7 +1922,7 @@ export class AdaptiveCardPeer extends TypedCardElementPeer[] = []; - for (var i = 0; i < context.hostContainer.actionsRegistry.getItemCount(); i++) { + for (let i = 0; i < context.hostContainer.actionsRegistry.getItemCount(); i++) { let typeRegistration = context.hostContainer.actionsRegistry.getItemAt(i); if (typeRegistration.schemaVersion.compareTo(context.targetVersion) <= 0) { @@ -2248,7 +2248,7 @@ export class ActionSetPeer extends TypedCardElementPeer { let availableActions: Adaptive.ITypeRegistration[] = []; - for (var i = 0; i < context.hostContainer.actionsRegistry.getItemCount(); i++) { + for (let i = 0; i < context.hostContainer.actionsRegistry.getItemCount(); i++) { let typeRegistration = context.hostContainer.actionsRegistry.getItemAt(i); if (typeRegistration.schemaVersion.compareTo(context.targetVersion) <= 0) { diff --git a/source/nodejs/adaptivecards-visualizer/src/app.ts b/source/nodejs/adaptivecards-visualizer/src/app.ts index 470ad47606..477ab7093e 100644 --- a/source/nodejs/adaptivecards-visualizer/src/app.ts +++ b/source/nodejs/adaptivecards-visualizer/src/app.ts @@ -187,7 +187,7 @@ function setupContainerPicker() { hostContainerPicker.addEventListener("change", hostContainerPickerChanged); - for (var i = 0; i < hostContainerOptions.length; i++) { + for (let i = 0; i < hostContainerOptions.length; i++) { var option = document.createElement("option"); option.value = hostContainerOptions[i].name; option.text = hostContainerOptions[i].name; @@ -234,7 +234,7 @@ function actionExecuted(action: Adaptive.Action) { message += " Method: " + httpAction.method + "\n"; message += " Headers:\n"; - for (var i = 0; i < httpAction.headers.length; i++) { + for (let i = 0; i < httpAction.headers.length; i++) { message += " " + httpAction.headers[i].name + ": " + httpAction.headers[i].value + "\n"; } @@ -282,7 +282,7 @@ function showValidationErrors() { var errorContainer = document.getElementById("errorContainer"); errorContainer.innerHTML = ""; - for (var i = 0; i < lastValidationErrors.length; i++) { + for (let i = 0; i < lastValidationErrors.length; i++) { var errorElement = document.createElement("div"); errorElement.innerText = lastValidationErrors[i].message; diff --git a/source/nodejs/adaptivecards-visualizer/src/containers/outlook.ts b/source/nodejs/adaptivecards-visualizer/src/containers/outlook.ts index 44adc21cb5..fcfc40d0cf 100644 --- a/source/nodejs/adaptivecards-visualizer/src/containers/outlook.ts +++ b/source/nodejs/adaptivecards-visualizer/src/containers/outlook.ts @@ -66,7 +66,7 @@ export class OutlookContainer extends HostContainer { if (typeof source["resources"] === "object") { var actionResources = source["resources"]["actions"] as Array; - for (var i = 0; i < actionResources.length; i++) { + for (let i = 0; i < actionResources.length; i++) { let action = Adaptive.GlobalRegistry.actions.createInstance(actionResources[i]["type"], context.targetVersion); if (action) { @@ -108,7 +108,7 @@ export class OutlookContainer extends HostContainer { if (rootCard) { var actionArray = rootCard["resources"]["actions"] as Array; - for (var i = 0; i < actionArray.length; i++) { + for (let i = 0; i < actionArray.length; i++) { if (actionArray[i].id == actionId) { actionArray[i].execute(); diff --git a/source/nodejs/adaptivecards/src/controls/popup-menu.ts b/source/nodejs/adaptivecards/src/controls/popup-menu.ts index 00a6747ff3..83bfe77e50 100644 --- a/source/nodejs/adaptivecards/src/controls/popup-menu.ts +++ b/source/nodejs/adaptivecards/src/controls/popup-menu.ts @@ -19,7 +19,7 @@ export class PopupMenu extends PopupControl { element.className = this.hostConfig.makeCssClassName("ac-ctrl ac-popup"); element.setAttribute("role", "listbox"); - for (var i = 0; i < this._items.length; i++) { + for (let i = 0; i < this._items.length; i++) { var renderedItem = this._items.get(i).render(this.hostConfig); renderedItem.tabIndex = 0;