From 4b1964f4c8f0f56a698bb31eaadd0ccafc9ed744 Mon Sep 17 00:00:00 2001 From: Michael Kuckuk Date: Sun, 21 Oct 2018 22:29:49 +0200 Subject: [PATCH 1/2] Remove . after "Initial commit" Commit message headlines should not be ended with periods, according to many guidelines such as https://chris.beams.io/posts/git-commit/#end and thus it should not be recommended in this README. This project's initial commit message headlines don't end with a period either. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0793532..59655b8 100644 --- a/README.md +++ b/README.md @@ -67,7 +67,7 @@ For it to run correctly, we'll need to initialize a git repository. ```sh git init git add . -git commit -m "Initial commit." +git commit -m "Initial commit" ``` > Note: if you've cloned this repository, you won't have to run the above at all. From 2128cb0dbe638adc16e36f799d87444ffe95d310 Mon Sep 17 00:00:00 2001 From: Michael Kuckuk Date: Sun, 21 Oct 2018 22:41:14 +0200 Subject: [PATCH 2/2] Add semicolons to match original code --- README.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 59655b8..672de9b 100644 --- a/README.md +++ b/README.md @@ -408,12 +408,12 @@ import Hello from './Hello'; it('renders the correct text when no enthusiasm level is given', () => { const hello = enzyme.shallow(); - expect(hello.find(".greeting").text()).toEqual('Hello Daniel!') + expect(hello.find(".greeting").text()).toEqual('Hello Daniel!'); }); it('renders the correct text with an explicit enthusiasm of 1', () => { const hello = enzyme.shallow(); - expect(hello.find(".greeting").text()).toEqual('Hello Daniel!') + expect(hello.find(".greeting").text()).toEqual('Hello Daniel!'); }); it('renders the correct text with an explicit enthusiasm level of 5', () => { @@ -656,7 +656,7 @@ export function mapStateToProps({ enthusiasmLevel, languageName }: StoreState) { return { enthusiasmLevel, name: languageName, - } + }; } ``` @@ -670,7 +670,7 @@ export function mapDispatchToProps(dispatch: Dispatch) return { onIncrement: () => dispatch(actions.incrementEnthusiasm()), onDecrement: () => dispatch(actions.decrementEnthusiasm()), - } + }; } ``` @@ -696,14 +696,14 @@ export function mapStateToProps({ enthusiasmLevel, languageName }: StoreState) { return { enthusiasmLevel, name: languageName, - } + }; } export function mapDispatchToProps(dispatch: Dispatch) { return { onIncrement: () => dispatch(actions.incrementEnthusiasm()), onDecrement: () => dispatch(actions.decrementEnthusiasm()), - } + }; } export default connect(mapStateToProps, mapDispatchToProps)(Hello);