TypeScriptServices.js and tsc.js use non-ES3 APIs

[mhegazy]

Here are instances of indexOf on an array I came across:

• src\compiler\checker.ts - (331, 32) : return sourceFiles.indexOf(file1) <= sourceFiles.indexOf(file2);
• src\compiler\checker.ts - (331, 62) : return sourceFiles.indexOf(file1) <= sourceFiles.indexOf(file2);
• src\compiler\checker.ts - (8514, 117) : return (parent).typeArguments && (parent).typeArguments.indexOf(node) >= 0;
• src\services\formatting\tokenRange.ts - (31, 32) : if (except.indexOf(token) < 0) {
• src\services\formatting\tokenRange.ts - (42, 36) : return this.tokens.indexOf(token) >= 0;
• src\services\formatting\tokenRange.ts - (64, 36) : return this.tokens.indexOf(token) >= 0;
• src\services\services.ts - (4373, 35) : if (searchSymbols.indexOf(referenceSymbol) >= 0) {
• src\services\services.ts - (4382, 110) : return forEach(typeInfoResolver.getRootSymbols(contextualSymbol), s => searchSymbols.indexOf(s) >= 0);
• src\services\services.ts - (4390, 39) : if (searchSymbols.indexOf(rootSymbol) >= 0) {
• src\services\services.ts - (4399, 67) : return forEach(result, s => searchSymbols.indexOf(s) >= 0);
• src\services\signatureHelp.ts - (263, 47) : var indexOfOpenerToken = children.indexOf(openerToken);
• src\services\signatureHelp.ts - (375, 48) : var selectedItemIndex = candidates.indexOf(bestSignature);

[sophiajt]

Should ES3 be the minimum supported by the compiler or should we switch to ES5?

[mhegazy]

this is one question, the second one is how to enforce it. currently the lib does not differentiate between ES3 and ES5 APIs. and similar cases will keep sneaking on us.