Color rendering issues

[tycho]

Most colors don't render properly. Below examples use this script.

MinTTY (Cygwin):

Bash on Windows:

[zadjii-msft]

Right now conhost's color support is limited to the default 16 ASCII colors, but 256 color support is most definitely high on the backlog of things we'd like to support in the near future!

[jbaribeault]

Great to hear!

[kilobyte]

256 color support is an addition that is in no way required.

This said, because of a misdesign they do need to be explicitly recognized in order to be ignored, otherwise the result is interpreted as random unrelated codes (example: printf 'foo\e[38;5;1mbar\e[0m\n'). Here's how to detect them: https://github.com/torvalds/linux/commit/3415097ff0529eac264b8ccfa06572871e45c090 (my comment that 24-bit is "extremely rare" is no longer true: https://gist.github.com/XVilka/8346728).

Adding actual support for 256/24-bit color to conhost would require significant API changes -- Windows Console is internally married to the 16 color scheme. Just like Linux console (VT not some X terminal) -- the most you can do is to try match nearest color. I did happen to implement that: torvalds/linux@cec5b2a

Microsoft guys: I hereby relicense these two commits, please feel free to use/adapt them.

[bitcrazed]

Fixed internally. Bubbling up through the build system.

[retep998]

@bitcrazed Will there also be an equivalent Windows API method to take advantage of the enhanced color support?

[zadjii-msft]

@retep998 At this time, the API surface isn't changing at all. We're not yet supporting full 256 color or 24 bit RGB yet - we're merely finding the nearest color from the 16-color table and using that to render the color for applications using those sequences. Unfortunately, supporting true 256 color requires a lot more work than was possible to get done for this update.

[fredrikaverpil]

Fixed internally. Bubbling up through the build system.

Just curious... when is this supposed to bubble out to insider previews?

[zerocool4u2]

14352

[dreyks]

@zerocool4u2 how did you get those fancy powerline symbols working? Did you install additional fonts?