Skip to content

feat: Enable BVT Container tests #17070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhagyapathak wants to merge 10 commits into from
Closed

feat: Enable BVT Container tests #17070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f5edbe7
Enable Container bvt tests and port some static google container tests
bhagyapathak May 7, 2026
9579df1
Handle PR comments
bhagyapathak May 12, 2026
ab036d0
Remove annotations of static & runtime tests
bhagyapathak May 12, 2026
32d92d5
Fix multi-arg @require_capability handling, auto-mark cases/*/runtime…
bhagyapathak May 12, 2026
2298bdd
Handle copilot suggestion
bhagyapathak May 12, 2026
dfa7d0a
fix: exclude runtime_container_tests from static-image-checks suite
Copilot May 12, 2026
5879618
Handle copilot suggestion iteration 2
bhagyapathak May 12, 2026
a7867fc
fix: make test_bvt_sustained_http_fetch configurable and skip when ne…
Copilot May 12, 2026
9d99f4c
fix: address review 4275221016 - marker description, image ref cachin…
Copilot May 12, 2026
743b470
fix: address review 4275818337 - public API, return type, pkg mgr det…
Copilot May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion base/images/images.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ runtime-package-management = true
[images.container-base]
description = "Container Base Image"
definition = { type = "kiwi", path = "container-base/container-base.kiwi", profile = "core" }
tests.test-suites = [{ name = "static-image-checks" }]
tests.test-suites = [
{ name = "static-image-checks" },
{ name = "container-bvt-tests" },
]
Comment thread
bhagyapathak marked this conversation as resolved.

[images.container-base.capabilities]
machine-bootable = false
Expand Down Expand Up @@ -61,4 +64,21 @@ extra-args = [
"--image-path", "{image-path}",
"--image-name", "{image-name}",
"--capabilities", "{capabilities}",
"-m", "not runtime_container_tests",
]

# Container Business Validation Tests (BVT)
[test-suites.container-bvt-tests]
type = "pytest"
description = "Container BVT: runtime validation of system resources, networking, filesystem, and package management"

[test-suites.container-bvt-tests.pytest]
working-dir = "tests"
install = "pyproject"
test-paths = ["cases/container-base/runtime/test_container_bvt.py"]
Copy link
Copy Markdown
Member

@reubeno reubeno May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just specify the whole runtime/ dir? But also, it's odd that the naming of the test suite implies it should be runnable against any container, but it's got a hard-coded reference to container-base in particular.

extra-args = [
"--image-path", "{image-path}",
"--image-name", "{image-name}",
"--capabilities", "{capabilities}",
"-v", "-s"
Copy link
Copy Markdown
Member

@reubeno reubeno May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to hard-code -v or -s in the test case, as that's a generic pytest option that the adapter for running pytest-based tests should be able to handle. azldev already does something like that, where it translates its own verbosity options to --log-cli-level. We could refine that, but it doesn't seem like should be test suite specific.

]
Loading