chore: migrate to eslint v9 (#33527)

Author: mainframev

apps/pr-deploy-site/.eslintrc.json

@@ -0,0 +1,29 @@
+const js = require('@eslint/js');
+const sdl = require('@microsoft/eslint-plugin-sdl');
+const es = require('eslint-plugin-es');
+const { FlatCompat } = require('@eslint/eslintrc');
+
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+module.exports = [
+  ...compat.extends('plugin:@fluentui/eslint-plugin/node'),
+  ...sdl.configs.recommended,
+  {
+    files: ['**/pr-deploy-site.js'],
+    plugins: {
+      es,
+    },
+
+    rules: {
+      curly: 'off',
+      'no-var': 'off',
+      'vars-on-top': 'off',
+      'prefer-arrow-callback': 'off',
+      'no-restricted-globals': 'off',
+    },
+  },
+];

apps/pr-deploy-site/eslint.config.js

@@ -7,7 +7,7 @@
   "scripts": {
     "clean": "just-scripts clean",
     "generate:site": "just-scripts generate:site",
-    "lint": "eslint --ext .js,.ts --cache .",
+    "lint": "eslint --cache .",
     "type-check": "tsc -p . --noEmit"
   },
   "license": "MIT",

apps/pr-deploy-site/package.json

@@ -20,7 +20,7 @@
     "build": "just-scripts build",
     "prebundle": "yarn build",
     "bundle": "just-scripts bundle",
-    "lint": "eslint --ext .js,.ts,.tsx ./src",
+    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint --ext .js,.ts,.tsx ./src",
     "just": "just-scripts",
     "clean": "just-scripts clean",
     "code-style": "just-scripts code-style",

apps/public-docsite-resources/package.json

@@ -68,7 +68,7 @@ export const AutoSizeForSmallViewport = () => {
           <MenuPopover>
             <MenuList>
               {Array.from({ length: menuItemCount }, (_, i) => (
-                <MenuItem>Item {i}</MenuItem>
+                <MenuItem key={i}>Item {i}</MenuItem>
               ))}
             </MenuList>
           </MenuPopover>

apps/public-docsite-v9/src/Concepts/Positioning/PositioningAutoSize.stories.tsx

@@ -112,7 +112,7 @@ export const CoverTargetForSmallViewport = () => {
           <MenuPopover>
             <MenuList>
               {Array.from({ length: menuItemCount }, (_, i) => (
-                <MenuItem>Item {i}</MenuItem>
+                <MenuItem key={i}>Item {i}</MenuItem>
               ))}
             </MenuList>
           </MenuPopover>

apps/public-docsite-v9/src/Concepts/Positioning/PositioningShiftToCoverTarget.stories.tsx

@@ -26,6 +26,7 @@ export const FabricIconsPage: React.FunctionComponent<IStylesPageProps> = props
 };
 
 function _otherSections(platform: Platforms): IPageSectionProps<Platforms>[] {
+  // eslint-disable-next-line react-hooks/rules-of-hooks
   const [selectedItem, setSelectedItem] = React.useState('react-font');
   switch (platform) {
     case 'web':

apps/public-docsite/src/pages/Styles/FabricIconsPage/FabricIconsPage.tsx

@@ -9,7 +9,7 @@
     "format:check": "yarn format -c",
     "e2e": "cypress run --component",
     "e2e:local": "cypress open --component",
-    "lint": "eslint --ext .js,.ts,.tsx ./src",
+    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint --ext .js,.ts,.tsx ./src",
     "test": "jest --passWithNoTests",
     "start": "webpack-dev-server --mode=development"
   },

apps/react-18-tests-v8/package.json

@@ -5,7 +5,7 @@
   "private": true,
   "scripts": {
     "type-check": "just-scripts type-check",
-    "lint": "eslint --ext .js,.ts,.tsx ./src",
+    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint --ext .js,.ts,.tsx ./src",
     "test": "jest --passWithNoTests",
     "format": "prettier -w . --ignore-path ../.prettierignore",
     "format:check": "yarn format -c",

apps/react-18-tests-v9/package.json

@@ -7,7 +7,7 @@
   "scripts": {
     "build-storybook": "storybook build -o dist/storybook",
     "format": "prettier . -w --ignore-path ../../.prettierignore",
-    "lint": "eslint src --ext .ts,.tsx",
+    "lint": "ESLINT_USE_FLAT_CONFIG=false eslint src --ext .ts,.tsx",
     "start": "storybook dev",
     "type-check": "tsc -p . --baseUrl . --noEmit",
     "test-vr": "storywright  --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true"