From 526a3dec4fc13fc9258ef1c95a054e0865c48159 Mon Sep 17 00:00:00 2001 From: Sarah Higley Date: Fri, 22 Oct 2021 19:13:44 -0700 Subject: [PATCH 1/2] remove explicit readonly semantics from grid --- .../CalendarMonth/CalendarMonth.base.tsx | 1 - .../CalendarYear/CalendarYear.base.tsx | 1 - .../CalendarDayGrid/CalendarDayGrid.base.tsx | 1 - .../CalendarDayGrid/CalendarGridDayCell.tsx | 1 - .../WeeklyDayPicker.test.tsx.snap | 44 ------------------- 5 files changed, 48 deletions(-) diff --git a/packages/react/src/components/Calendar/CalendarMonth/CalendarMonth.base.tsx b/packages/react/src/components/Calendar/CalendarMonth/CalendarMonth.base.tsx index 4a2661b9df1373..83414013d3146f 100644 --- a/packages/react/src/components/Calendar/CalendarMonth/CalendarMonth.base.tsx +++ b/packages/react/src/components/Calendar/CalendarMonth/CalendarMonth.base.tsx @@ -292,7 +292,6 @@ export const CalendarMonthBase: React.FunctionComponent = p aria-selected={isNavigatedMonth} data-is-focusable={isInBounds ? true : undefined} type="button" - aria-readonly={true} // prevent grid from being "editable" > {month} diff --git a/packages/react/src/components/Calendar/CalendarYear/CalendarYear.base.tsx b/packages/react/src/components/Calendar/CalendarYear/CalendarYear.base.tsx index c19df3c0f3d562..10eb5880f2f26c 100644 --- a/packages/react/src/components/Calendar/CalendarYear/CalendarYear.base.tsx +++ b/packages/react/src/components/Calendar/CalendarYear/CalendarYear.base.tsx @@ -104,7 +104,6 @@ const CalendarYearGridCell: React.FunctionComponent disabled={disabled} aria-selected={selected} ref={buttonRef} - aria-readonly={true} // prevent grid from being "editable" > {onRenderYear?.(year) ?? year} diff --git a/packages/react/src/components/CalendarDayGrid/CalendarDayGrid.base.tsx b/packages/react/src/components/CalendarDayGrid/CalendarDayGrid.base.tsx index 2d04a4c0264f1c..fe6d0b69eba9c2 100644 --- a/packages/react/src/components/CalendarDayGrid/CalendarDayGrid.base.tsx +++ b/packages/react/src/components/CalendarDayGrid/CalendarDayGrid.base.tsx @@ -384,7 +384,6 @@ export const CalendarDayGridBase: React.FunctionComponent diff --git a/packages/react/src/components/WeeklyDayPicker/__snapshots__/WeeklyDayPicker.test.tsx.snap b/packages/react/src/components/WeeklyDayPicker/__snapshots__/WeeklyDayPicker.test.tsx.snap index 11508f38dc2d0a..99c6cd3e01e8b1 100644 --- a/packages/react/src/components/WeeklyDayPicker/__snapshots__/WeeklyDayPicker.test.tsx.snap +++ b/packages/react/src/components/WeeklyDayPicker/__snapshots__/WeeklyDayPicker.test.tsx.snap @@ -132,7 +132,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
Date: Fri, 22 Oct 2021 19:14:36 -0700 Subject: [PATCH 2/2] Change files --- ...luentui-react-aa326f44-85e1-4622-a538-74cc288024e0.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-aa326f44-85e1-4622-a538-74cc288024e0.json diff --git a/change/@fluentui-react-aa326f44-85e1-4622-a538-74cc288024e0.json b/change/@fluentui-react-aa326f44-85e1-4622-a538-74cc288024e0.json new file mode 100644 index 00000000000000..41a3943b02e482 --- /dev/null +++ b/change/@fluentui-react-aa326f44-85e1-4622-a538-74cc288024e0.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Remove explicit readonly semantics from Calendar grid", + "packageName": "@fluentui/react", + "email": "sarah.higley@microsoft.com", + "dependentChangeType": "patch" +}