From 27cd107b80adab7f8d777cf1ed5f0799560814e6 Mon Sep 17 00:00:00 2001 From: Sarah Higley Date: Wed, 6 Apr 2022 13:04:07 -0700 Subject: [PATCH 1/2] update a11y issue template, and add a11y test to convergence checklist --- .github/ISSUE_TEMPLATE/bug-report.yml | 6 ++---- .github/ISSUE_TEMPLATE/convergence_epic.md | 1 + 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index f685c1535f549a..cdb08c5fde13f4 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -39,10 +39,8 @@ body: **PLEASE NOTE:** 1. Do not link to, screenshot or reference a Microsoft product in this description. - 2. Our screen reader support is limited to Edge + Narrator. - - Please check ARIA component examples to ensure it is not a screen reader or browser issue. - - Issues that do not reproduce in Edge + Narrator, and aren't caused by obvious invalid aria values, should be filed with the respective screen reading software, not the Fluent UI repo. - 3. There is documentation or best practice that supports your expected behavior (review [WAI-ARIA](https://www.w3.org/TR/wai-aria-1.1/) for accessibility guidance.) + 2. Please check ARIA component examples to ensure it is not a screen reader or browser issue. If the issue concerns screen reader behavior that reproduces on HTML elements or ARIA Practices examples (https://w3c.github.io/aria-practices/), it should be filed with the respective browser or screen reading software and not the Fluent UI repo. + 3. There is documentation or best practice info to support your expected behavior (review https://w3c.github.io/aria/ for accessibility guidance.) options: - 'yes' - 'no' diff --git a/.github/ISSUE_TEMPLATE/convergence_epic.md b/.github/ISSUE_TEMPLATE/convergence_epic.md index 9bf9f601a55034..9067e7d694f68a 100644 --- a/.github/ISSUE_TEMPLATE/convergence_epic.md +++ b/.github/ISSUE_TEMPLATE/convergence_epic.md @@ -39,6 +39,7 @@ completed as part of converging a component. More info can be found here: https: - [ ] Unit tests - [ ] VR tests - [ ] Accessibility behavior tests + - [ ] Create an issue and run [manual accessibility tests](https://github.com/microsoft/fluentui/wiki/Manual-Accessibility-Review-Checklist): (issue link) - [ ] Write README.md covering basic usage - [ ] Write initial MIGRATION.md guide (include v8 and v0) - [ ] Set component ownership in CODEOWNERS From 25b6c01c3ca9c468c8a1c461e609bffbd2ce579d Mon Sep 17 00:00:00 2001 From: Sarah Higley Date: Wed, 6 Apr 2022 14:22:09 -0700 Subject: [PATCH 2/2] add wording about internal tracker --- .github/ISSUE_TEMPLATE/bug-report.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index cdb08c5fde13f4..9f287c63e13ab0 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -41,6 +41,9 @@ body: 1. Do not link to, screenshot or reference a Microsoft product in this description. 2. Please check ARIA component examples to ensure it is not a screen reader or browser issue. If the issue concerns screen reader behavior that reproduces on HTML elements or ARIA Practices examples (https://w3c.github.io/aria-practices/), it should be filed with the respective browser or screen reading software and not the Fluent UI repo. 3. There is documentation or best practice info to support your expected behavior (review https://w3c.github.io/aria/ for accessibility guidance.) + + **Additional note for Microsoft employees:** + Please file accessibility issues in our internal tracker (http://aka.ms/fluentui-a11y). This helps with tracking accessibility progress within the company. options: - 'yes' - 'no'