From 3c02f5595b514a2b9d2933d40e7839f5b132f90c Mon Sep 17 00:00:00 2001 From: Anton Labunets Date: Fri, 2 Sep 2016 09:53:17 -0700 Subject: [PATCH 1/2] Fixing high contrast for Link --- src/common/_fabricExtraColors.scss | 3 +++ src/components/Link/Link.scss | 8 +++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/common/_fabricExtraColors.scss b/src/common/_fabricExtraColors.scss index 9cf758b481ecfa..6ca559446601b6 100644 --- a/src/common/_fabricExtraColors.scss +++ b/src/common/_fabricExtraColors.scss @@ -1,2 +1,5 @@ $ms-color-neutralQuaternary: #d0d0d0; $ms-color-neutralQuaternaryAlt: #dadada; +// Overriding link colors that are incorrect in fabric core while +// waiting on https://github.com/OfficeDev/office-ui-fabric-core/pull/793/files +$ms-color-contrastBlackLink: #FFFF00 diff --git a/src/components/Link/Link.scss b/src/components/Link/Link.scss index 3c9fcaed05f176..8f931323c53d97 100644 --- a/src/components/Link/Link.scss +++ b/src/components/Link/Link.scss @@ -23,12 +23,18 @@ } @media screen and (-ms-high-contrast: active) { - color: $ms-color-contrastBlackLink; + &:hover { + text-decoration: underline; + } } @media screen and (-ms-high-contrast: black-on-white) { color: $ms-color-contrastWhiteLink; } + + @media screen and (-ms-high-contrast: white-on-black) { + color: $ms-color-contrastBlackLink; + } } .ms-Link { From ce0a0475efa61919b3598dba063e2af19447a6d4 Mon Sep 17 00:00:00 2001 From: Anton Labunets Date: Tue, 6 Sep 2016 09:43:05 -0700 Subject: [PATCH 2/2] Remove the overrides to enable customization of colors --- src/common/_fabricExtraColors.scss | 3 --- src/components/Link/Link.scss | 14 -------------- 2 files changed, 17 deletions(-) diff --git a/src/common/_fabricExtraColors.scss b/src/common/_fabricExtraColors.scss index 6ca559446601b6..9cf758b481ecfa 100644 --- a/src/common/_fabricExtraColors.scss +++ b/src/common/_fabricExtraColors.scss @@ -1,5 +1,2 @@ $ms-color-neutralQuaternary: #d0d0d0; $ms-color-neutralQuaternaryAlt: #dadada; -// Overriding link colors that are incorrect in fabric core while -// waiting on https://github.com/OfficeDev/office-ui-fabric-core/pull/793/files -$ms-color-contrastBlackLink: #FFFF00 diff --git a/src/components/Link/Link.scss b/src/components/Link/Link.scss index 8f931323c53d97..c1eeaeaa9c334f 100644 --- a/src/components/Link/Link.scss +++ b/src/components/Link/Link.scss @@ -21,20 +21,6 @@ &:active { color: $ms-color-themePrimary; } - - @media screen and (-ms-high-contrast: active) { - &:hover { - text-decoration: underline; - } - } - - @media screen and (-ms-high-contrast: black-on-white) { - color: $ms-color-contrastWhiteLink; - } - - @media screen and (-ms-high-contrast: white-on-black) { - color: $ms-color-contrastBlackLink; - } } .ms-Link {