From 3a4b9aeb4ba5b2c7f8cc046ad9a6d1a6828ed12a Mon Sep 17 00:00:00 2001 From: Sarah Higley Date: Tue, 19 Jul 2022 11:56:56 -0700 Subject: [PATCH 1/4] Remove explicit readonly semantics from Calendar grid --- .../CalendarYear/CalendarYear.base.tsx | 1 - .../CalendarDayGrid/CalendarDayGrid.base.tsx | 1 - .../CalendarDayGrid/CalendarGridDayCell.tsx | 1 - .../WeeklyDayPicker.test.tsx.snap | 44 ------------------- .../src/components/Calendar/CalendarMonth.tsx | 2 +- .../__snapshots__/Calendar.test.tsx.snap | 1 - 6 files changed, 1 insertion(+), 49 deletions(-) diff --git a/packages/date-time/src/components/Calendar/CalendarYear/CalendarYear.base.tsx b/packages/date-time/src/components/Calendar/CalendarYear/CalendarYear.base.tsx index b598d8258c202..6f8fdb84b8bd4 100644 --- a/packages/date-time/src/components/Calendar/CalendarYear/CalendarYear.base.tsx +++ b/packages/date-time/src/components/Calendar/CalendarYear/CalendarYear.base.tsx @@ -112,7 +112,6 @@ const CalendarYearGridCell = React.forwardRef( aria-label={String(year)} aria-selected={selected} ref={mergedRef} - aria-readonly={true} // prevent grid from being "editable" > {onRenderYear?.(year) ?? year} diff --git a/packages/date-time/src/components/CalendarDayGrid/CalendarDayGrid.base.tsx b/packages/date-time/src/components/CalendarDayGrid/CalendarDayGrid.base.tsx index 4cd323649f07d..cb48245a714a5 100644 --- a/packages/date-time/src/components/CalendarDayGrid/CalendarDayGrid.base.tsx +++ b/packages/date-time/src/components/CalendarDayGrid/CalendarDayGrid.base.tsx @@ -367,7 +367,6 @@ export const CalendarDayGridBase = React.forwardRef(
-
+
{rowIndexes.map((rowNum: number) => { const monthsForRow = strings.shortMonths.slice(rowNum * MONTHS_PER_ROW, (rowNum + 1) * MONTHS_PER_ROW); return ( diff --git a/packages/office-ui-fabric-react/src/components/Calendar/__snapshots__/Calendar.test.tsx.snap b/packages/office-ui-fabric-react/src/components/Calendar/__snapshots__/Calendar.test.tsx.snap index bab60829bafef..b1df2d05f33dc 100644 --- a/packages/office-ui-fabric-react/src/components/Calendar/__snapshots__/Calendar.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/Calendar/__snapshots__/Calendar.test.tsx.snap @@ -1208,7 +1208,6 @@ exports[`Calendar Test rendering simplest calendar Renders simple calendar corre onMouseDownCapture={[Function]} >
From 9f71368db6d9dcc2f227948fdb66d11c641bb6bc Mon Sep 17 00:00:00 2001 From: Sarah Higley Date: Tue, 19 Jul 2022 11:57:17 -0700 Subject: [PATCH 2/4] Change files --- ...ric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json | 7 +++++++ ...-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json | 7 +++++++ 2 files changed, 14 insertions(+) create mode 100644 change/@uifabric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json create mode 100644 change/office-ui-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json diff --git a/change/@uifabric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json b/change/@uifabric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json new file mode 100644 index 0000000000000..03df9b2320866 --- /dev/null +++ b/change/@uifabric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Remove explicit readonly semantics from Calendar grid", + "packageName": "@uifabric/date-time", + "email": "sarah.higley@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/change/office-ui-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json b/change/office-ui-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json new file mode 100644 index 0000000000000..931485124d326 --- /dev/null +++ b/change/office-ui-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Remove explicit readonly semantics from Calendar grid", + "packageName": "office-ui-fabric-react", + "email": "sarah.higley@microsoft.com", + "dependentChangeType": "patch" +} From eafef66a23aa4fe32280c14c36ea2c7a97f4d356 Mon Sep 17 00:00:00 2001 From: Sarah Higley Date: Tue, 19 Jul 2022 14:01:29 -0700 Subject: [PATCH 3/4] better change file comment Co-authored-by: Makoto Morimoto --- ...uifabric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/change/@uifabric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json b/change/@uifabric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json index 03df9b2320866..e8fb5bef3583d 100644 --- a/change/@uifabric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json +++ b/change/@uifabric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json @@ -1,6 +1,6 @@ { "type": "patch", - "comment": "Remove explicit readonly semantics from Calendar grid", + "comment": "fix: Remove explicit readonly semantics from Calendar grid.", "packageName": "@uifabric/date-time", "email": "sarah.higley@microsoft.com", "dependentChangeType": "patch" From 742929cc7dce7f43de3ff9bbfee567a1347062fb Mon Sep 17 00:00:00 2001 From: Sarah Higley Date: Tue, 19 Jul 2022 14:01:37 -0700 Subject: [PATCH 4/4] better change file comment Co-authored-by: Makoto Morimoto --- ...ce-ui-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/change/office-ui-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json b/change/office-ui-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json index 931485124d326..e435c078503b4 100644 --- a/change/office-ui-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json +++ b/change/office-ui-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json @@ -1,6 +1,6 @@ { "type": "patch", - "comment": "Remove explicit readonly semantics from Calendar grid", + "comment": "fix: Remove explicit readonly semantics from Calendar grid.", "packageName": "office-ui-fabric-react", "email": "sarah.higley@microsoft.com", "dependentChangeType": "patch"