From e1f61f7c1bfb5c412e7d103d22e316842abf572f Mon Sep 17 00:00:00 2001 From: Esteban Munoz Date: Wed, 24 Aug 2022 12:19:55 -0600 Subject: [PATCH 1/3] feat: Adding filled with shadow appearance. --- .../react-textarea/etc/react-textarea.api.md | 2 +- .../src/components/Textarea/Textarea.types.ts | 2 +- .../components/Textarea/useTextareaStyles.ts | 12 ++++++++++ .../Textarea/TextareaAppearance.stories.tsx | 22 +++++++++++++++++++ 4 files changed, 36 insertions(+), 2 deletions(-) diff --git a/packages/react-components/react-textarea/etc/react-textarea.api.md b/packages/react-components/react-textarea/etc/react-textarea.api.md index bb5841e720352..033194d9e76a7 100644 --- a/packages/react-components/react-textarea/etc/react-textarea.api.md +++ b/packages/react-components/react-textarea/etc/react-textarea.api.md @@ -22,7 +22,7 @@ export const textareaClassNames: SlotClassNames; // @public export type TextareaProps = Omit, 'textarea'>, 'defaultValue' | 'onChange' | 'size' | 'value'> & { - appearance?: 'outline' | 'filled-darker' | 'filled-lighter'; + appearance?: 'outline' | 'filled-darker' | 'filled-lighter' | 'filled-darker-shadow' | 'filled-lighter-shadow'; defaultValue?: string; onChange?: (ev: React_2.ChangeEvent, data: TextareaOnChangeData) => void; resize?: 'none' | 'horizontal' | 'vertical' | 'both'; diff --git a/packages/react-components/react-textarea/src/components/Textarea/Textarea.types.ts b/packages/react-components/react-textarea/src/components/Textarea/Textarea.types.ts index ef54e1aced954..2d5e48c713285 100644 --- a/packages/react-components/react-textarea/src/components/Textarea/Textarea.types.ts +++ b/packages/react-components/react-textarea/src/components/Textarea/Textarea.types.ts @@ -28,7 +28,7 @@ export type TextareaProps = Omit< * * @default outline */ - appearance?: 'outline' | 'filled-darker' | 'filled-lighter'; + appearance?: 'outline' | 'filled-darker' | 'filled-lighter' | 'filled-darker-shadow' | 'filled-lighter-shadow'; /** * The default value of the Textarea. diff --git a/packages/react-components/react-textarea/src/components/Textarea/useTextareaStyles.ts b/packages/react-components/react-textarea/src/components/Textarea/useTextareaStyles.ts index 3b341e7de1eb0..76b0881dad42f 100644 --- a/packages/react-components/react-textarea/src/components/Textarea/useTextareaStyles.ts +++ b/packages/react-components/react-textarea/src/components/Textarea/useTextareaStyles.ts @@ -112,6 +112,18 @@ const useRootStyles = makeStyles({ ...shorthands.border(tokens.strokeWidthThin, 'solid', tokens.colorTransparentStrokeInteractive), }, + 'filled-darker-shadow': { + backgroundColor: tokens.colorNeutralBackground3, + ...shorthands.border(tokens.strokeWidthThin, 'solid', tokens.colorTransparentStrokeInteractive), + boxShadow: tokens.shadow2, + }, + + 'filled-lighter-shadow': { + backgroundColor: tokens.colorNeutralBackground1, + ...shorthands.border(tokens.strokeWidthThin, 'solid', tokens.colorTransparentStrokeInteractive), + boxShadow: tokens.shadow2, + }, + outline: { backgroundColor: tokens.colorNeutralBackground1, ...shorthands.border(tokens.strokeWidthThin, 'solid', tokens.colorNeutralStroke1), diff --git a/packages/react-components/react-textarea/src/stories/Textarea/TextareaAppearance.stories.tsx b/packages/react-components/react-textarea/src/stories/Textarea/TextareaAppearance.stories.tsx index 37a036322e03e..c7854cb481561 100644 --- a/packages/react-components/react-textarea/src/stories/Textarea/TextareaAppearance.stories.tsx +++ b/packages/react-components/react-textarea/src/stories/Textarea/TextareaAppearance.stories.tsx @@ -35,7 +35,9 @@ const useStyles = makeStyles({ export const Appearance = () => { const outlineId = useId('textarea-outline'); const filledDarkerId = useId('textarea-filleddarker'); + const filledDarkerShadowId = useId('textarea-filleddarkershadow'); const filledLighterId = useId('textarea-filledlighter'); + const filledLighterShadowId = useId('textarea-filledlightershadow'); const styles = useStyles(); return ( @@ -54,6 +56,26 @@ export const Appearance = () => {