From 41492a6f690f2ea5659943b91fc0a58b6343cdc5 Mon Sep 17 00:00:00 2001 From: Micah Godbolt Date: Thu, 15 Sep 2022 13:24:51 -0700 Subject: [PATCH 1/3] fix: Add explicit children prop to TeachingBubble to support React 18 --- .../react/src/components/TeachingBubble/TeachingBubble.types.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react/src/components/TeachingBubble/TeachingBubble.types.ts b/packages/react/src/components/TeachingBubble/TeachingBubble.types.ts index b85bc091baa69d..91f1ba6a7ac061 100644 --- a/packages/react/src/components/TeachingBubble/TeachingBubble.types.ts +++ b/packages/react/src/components/TeachingBubble/TeachingBubble.types.ts @@ -21,6 +21,8 @@ export interface ITeachingBubble { * {@docCategory TeachingBubble} */ export interface ITeachingBubbleProps extends React.RefAttributes, IAccessiblePopupProps { + children?: React.ReactNode; + /** * Optional callback to access the ITeachingBubble interface. Use this instead of ref for accessing * the public methods and properties of the component. From 0b9c68711f46092b6fb6a657472b2ee7f5ae2114 Mon Sep 17 00:00:00 2001 From: Micah Godbolt Date: Thu, 15 Sep 2022 13:27:55 -0700 Subject: [PATCH 2/3] change file --- ...luentui-react-ea32524a-6ed8-4a2c-bbda-87c6389f2dd1.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-ea32524a-6ed8-4a2c-bbda-87c6389f2dd1.json diff --git a/change/@fluentui-react-ea32524a-6ed8-4a2c-bbda-87c6389f2dd1.json b/change/@fluentui-react-ea32524a-6ed8-4a2c-bbda-87c6389f2dd1.json new file mode 100644 index 00000000000000..e89909cc74493c --- /dev/null +++ b/change/@fluentui-react-ea32524a-6ed8-4a2c-bbda-87c6389f2dd1.json @@ -0,0 +1,7 @@ +{ + "type": "minor", + "comment": "fix: Add explicit children prop to TeachingBubble to support React 18", + "packageName": "@fluentui/react", + "email": "mgodbolt@microsoft.com", + "dependentChangeType": "patch" +} From 9d57533156e8d4e7e55c2506a7b149f79b692523 Mon Sep 17 00:00:00 2001 From: Micah Godbolt Date: Thu, 15 Sep 2022 16:03:22 -0700 Subject: [PATCH 3/3] api --- packages/react/etc/react.api.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react/etc/react.api.md b/packages/react/etc/react.api.md index cec44a35208fad..5b03eb7fb6b4b2 100644 --- a/packages/react/etc/react.api.md +++ b/packages/react/etc/react.api.md @@ -9105,6 +9105,8 @@ export interface ITeachingBubbleProps extends React_2.RefAttributes; focusTrapZoneProps?: IFocusTrapZoneProps; footerContent?: string | JSX.Element;