From bd08b7448172c37e09027e3751ade3b85f963837 Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Mon, 10 Apr 2023 13:05:02 +0530 Subject: [PATCH 01/16] Fix triangle pyramid shape --- packages/react-charting/src/components/Legends/shape.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-charting/src/components/Legends/shape.tsx b/packages/react-charting/src/components/Legends/shape.tsx index 91cd3135771417..a0a6777862e87e 100644 --- a/packages/react-charting/src/components/Legends/shape.tsx +++ b/packages/react-charting/src/components/Legends/shape.tsx @@ -36,7 +36,7 @@ export const Shape: React.FC = ({ svgProps, pathProps, shape, class height={14} viewBox={'-1 -1 14 14'} {...svgProps} - transform={`rotate(${shape === Points[Points.diamond] ? 45 : shape === Points[Points.triangle] ? 180 : 0}, 0, 0)`} + transform={`rotate(${shape === Points[Points.diamond] ? 45 : shape === Points[Points.pyramid] ? 180 : 0}, 0, 0)`} > From b6fb8c27b81d97d3019467c03729942327048f78 Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Mon, 10 Apr 2023 13:07:26 +0530 Subject: [PATCH 02/16] Add changefile --- ...eact-charting-b2276f17-5bf5-4574-8ed6-a32817b67107.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-charting-b2276f17-5bf5-4574-8ed6-a32817b67107.json diff --git a/change/@fluentui-react-charting-b2276f17-5bf5-4574-8ed6-a32817b67107.json b/change/@fluentui-react-charting-b2276f17-5bf5-4574-8ed6-a32817b67107.json new file mode 100644 index 00000000000000..c7c967ff912017 --- /dev/null +++ b/change/@fluentui-react-charting-b2276f17-5bf5-4574-8ed6-a32817b67107.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Fix shape of triangle and pyramid", + "packageName": "@fluentui/react-charting", + "email": "atishay.jain@microsoft.com", + "dependentChangeType": "patch" +} From a6542c75ae3dbe7c238d169698f346f61ed873c8 Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Thu, 13 Apr 2023 13:57:59 +0530 Subject: [PATCH 03/16] Add react charting to fabric group --- .../src/utilities/defaultSupportedPackages.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts index 71715d02e3fb0d..26787b5f1edb60 100644 --- a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts +++ b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts @@ -70,6 +70,7 @@ if (typesContext) { { packageName: '@fluentui/style-utilities', loadTypes }, { packageName: '@fluentui/theme', loadTypes }, { packageName: '@fluentui/utilities', loadTypes }, + { packageName: '@fluentui/react-charting', loadTypes }, ); hooksGroup.packages.push({ packageName: '@fluentui/react-hooks', loadTypes }); exampleDataGroup.packages.push({ packageName: '@fluentui/example-data', loadTypes }); From a03a93f7a0e90196df85ceb7a0e7e0a761db408c Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Thu, 13 Apr 2023 14:06:13 +0530 Subject: [PATCH 04/16] Add change file --- ...monaco-editor-eacbbb2f-ad95-4072-81d7-0d97fa23090f.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-monaco-editor-eacbbb2f-ad95-4072-81d7-0d97fa23090f.json diff --git a/change/@fluentui-react-monaco-editor-eacbbb2f-ad95-4072-81d7-0d97fa23090f.json b/change/@fluentui-react-monaco-editor-eacbbb2f-ad95-4072-81d7-0d97fa23090f.json new file mode 100644 index 00000000000000..a14c3d39ca0a15 --- /dev/null +++ b/change/@fluentui-react-monaco-editor-eacbbb2f-ad95-4072-81d7-0d97fa23090f.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Add react charting to support export to codepen", + "packageName": "@fluentui/react-monaco-editor", + "email": "atishay.jain@microsoft.com", + "dependentChangeType": "patch" +} From 31c6380e64c1d15e9c8a362f26e5c55b09ea1532 Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Thu, 13 Apr 2023 14:40:09 +0530 Subject: [PATCH 05/16] Add test change in line chart --- .../src/components/LineChart/LineChart.base.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/react-charting/src/components/LineChart/LineChart.base.tsx b/packages/react-charting/src/components/LineChart/LineChart.base.tsx index 86a5db5dbcd80a..9997fa01973ee4 100644 --- a/packages/react-charting/src/components/LineChart/LineChart.base.tsx +++ b/packages/react-charting/src/components/LineChart/LineChart.base.tsx @@ -277,7 +277,7 @@ export class LineChartBase extends React.Component { + this._refCallback(e!, circleId); + }} onMouseOver={this._handleHover.bind( this, x1, @@ -565,6 +569,7 @@ export class LineChartBase extends React.Component this._handleFocus(circleId, x1, xAxisCalloutData, circleId, xAxisCalloutAccessibilityData)} onMouseOut={this._handleMouseOut} strokeWidth={activePoint === circleId ? DEFAULT_LINE_STROKE_SIZE : 0} stroke={activePoint === circleId ? lineColor : ''} From 61a68ae0a1477880c006ec014ae5a44da9733516 Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Thu, 13 Apr 2023 17:33:17 +0530 Subject: [PATCH 06/16] Add react charting to codepen supported packages --- .../components/CodepenComponent/CodepenComponent.tsx | 4 ++++ .../src/utilities/defaultSupportedPackages.ts | 11 +++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/packages/react-docsite-components/src/components/CodepenComponent/CodepenComponent.tsx b/packages/react-docsite-components/src/components/CodepenComponent/CodepenComponent.tsx index d3593c6aa29d96..d7032f452a6489 100644 --- a/packages/react-docsite-components/src/components/CodepenComponent/CodepenComponent.tsx +++ b/packages/react-docsite-components/src/components/CodepenComponent/CodepenComponent.tsx @@ -48,6 +48,10 @@ const CodepenComponentBase: React.FunctionComponent = props => { jsContentStr.indexOf('window.FluentUIExampleData') !== -1 ? script('@fluentui/example-data@8/dist/example-data.js') : '', + // load charting bundle only if used + jsContentStr.indexOf('window.FluentUIReactCharting') !== -1 + ? script('@fluentui/react-charting@5/dist/react-charting.js') + : '', `
`, ] .filter(line => !!line) diff --git a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts index 26787b5f1edb60..1a2e93e6eae293 100644 --- a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts +++ b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts @@ -18,6 +18,11 @@ const exampleDataGroup: IPackageGroup = { loadGlobal: cb => require.ensure([], require => cb(require('@fluentui/example-data'))), packages: [], }; +const chartingGroup: IPackageGroup = { + globalName: 'FluentUIReactCharting', + loadGlobal: cb => require.ensure([], require => cb(require('@fluentui/react-charting'))), + packages: [], +}; let typesContext: __WebpackModuleApi.RequireContext | undefined; try { @@ -44,6 +49,8 @@ if (typesContext) { ? exampleDataGroup : packageName === '@fluentui/react-hooks' ? hooksGroup + : packageName === '@fluentui/react-charting' + ? chartingGroup : fabricGroup; packageGroup.packages.push({ packageName, @@ -70,14 +77,14 @@ if (typesContext) { { packageName: '@fluentui/style-utilities', loadTypes }, { packageName: '@fluentui/theme', loadTypes }, { packageName: '@fluentui/utilities', loadTypes }, - { packageName: '@fluentui/react-charting', loadTypes }, ); hooksGroup.packages.push({ packageName: '@fluentui/react-hooks', loadTypes }); exampleDataGroup.packages.push({ packageName: '@fluentui/example-data', loadTypes }); + chartingGroup.packages.push({ packageName: '@fluentui/react-charting', loadTypes }); } /** * Default supported packages for imports: `@fluentui/react` and everything it exports, * plus `@fluentui/example-data`. (React is implicitly supported.) */ -export const SUPPORTED_PACKAGES: IPackageGroup[] = [fabricGroup, hooksGroup, exampleDataGroup]; +export const SUPPORTED_PACKAGES: IPackageGroup[] = [fabricGroup, hooksGroup, exampleDataGroup, chartingGroup]; From 1d026ff6afdfed906ff07b0c0a92f5b8e62d34f3 Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Thu, 13 Apr 2023 22:08:22 +0530 Subject: [PATCH 07/16] Test adding charting as dependency for monaco editor --- packages/react-monaco-editor/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-monaco-editor/package.json b/packages/react-monaco-editor/package.json index 68f831f316138b..8e5e8a8834c82c 100644 --- a/packages/react-monaco-editor/package.json +++ b/packages/react-monaco-editor/package.json @@ -33,6 +33,7 @@ "@fluentui/react": "^8.107.3", "@microsoft/load-themed-styles": "^1.10.26", "@fluentui/example-data": "^8.4.7", + "@fluentui/react-charting": "^5.16.13", "@fluentui/monaco-editor": "^1.3.6", "@fluentui/react-hooks": "^8.6.20", "raw-loader": "4.0.2", From 814d183da993b1c3f6322724dd880a7a143128ff Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Mon, 17 Apr 2023 16:47:08 +0530 Subject: [PATCH 08/16] Add charting package as default supported --- packages/react-monaco-editor/package.json | 1 - .../src/utilities/defaultSupportedPackages.ts | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-monaco-editor/package.json b/packages/react-monaco-editor/package.json index 8e5e8a8834c82c..68f831f316138b 100644 --- a/packages/react-monaco-editor/package.json +++ b/packages/react-monaco-editor/package.json @@ -33,7 +33,6 @@ "@fluentui/react": "^8.107.3", "@microsoft/load-themed-styles": "^1.10.26", "@fluentui/example-data": "^8.4.7", - "@fluentui/react-charting": "^5.16.13", "@fluentui/monaco-editor": "^1.3.6", "@fluentui/react-hooks": "^8.6.20", "raw-loader": "4.0.2", diff --git a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts index 1a2e93e6eae293..b738bc25f83bea 100644 --- a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts +++ b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts @@ -80,8 +80,9 @@ if (typesContext) { ); hooksGroup.packages.push({ packageName: '@fluentui/react-hooks', loadTypes }); exampleDataGroup.packages.push({ packageName: '@fluentui/example-data', loadTypes }); - chartingGroup.packages.push({ packageName: '@fluentui/react-charting', loadTypes }); } +const loadTypes = () => ''; +chartingGroup.packages.push({ packageName: '@fluentui/react-charting', loadTypes }); /** * Default supported packages for imports: `@fluentui/react` and everything it exports, From 00b8c96d62971deb9a629e1f3f68d1a3b5e1103b Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Mon, 17 Apr 2023 21:09:41 +0530 Subject: [PATCH 09/16] Add change file for react docsite component --- ...te-components-7f162818-fcb4-4cbe-8dc1-6d855e04b980.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-docsite-components-7f162818-fcb4-4cbe-8dc1-6d855e04b980.json diff --git a/change/@fluentui-react-docsite-components-7f162818-fcb4-4cbe-8dc1-6d855e04b980.json b/change/@fluentui-react-docsite-components-7f162818-fcb4-4cbe-8dc1-6d855e04b980.json new file mode 100644 index 00000000000000..e2cdde7c9ca42f --- /dev/null +++ b/change/@fluentui-react-docsite-components-7f162818-fcb4-4cbe-8dc1-6d855e04b980.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Enable export to codepen for react charting", + "packageName": "@fluentui/react-docsite-components", + "email": "atishay.jain@microsoft.com", + "dependentChangeType": "patch" +} From e7e66ba91f334bb077f49b0f2ae5c4adbc46c9ca Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Mon, 17 Apr 2023 21:34:54 +0530 Subject: [PATCH 10/16] Put charting package under a condition --- .../src/utilities/defaultSupportedPackages.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts index b738bc25f83bea..699f8838fb56ba 100644 --- a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts +++ b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts @@ -37,6 +37,7 @@ try { } catch (ex) { // We're probably running in jest, which doesn't have webpack's require.context } +const loadTypes = () => ''; if (typesContext) { typesContext.keys().forEach(dtsPath => { // The api-extractor .d.ts rollups use the package's unscoped name (such as "utilities") @@ -49,8 +50,6 @@ if (typesContext) { ? exampleDataGroup : packageName === '@fluentui/react-hooks' ? hooksGroup - : packageName === '@fluentui/react-charting' - ? chartingGroup : fabricGroup; packageGroup.packages.push({ packageName, @@ -64,7 +63,6 @@ if (typesContext) { }); } else { // Use some defaults for jest tests (real types won't be loaded) - const loadTypes = () => ''; fabricGroup.packages.push( { packageName: '@fluentui/date-time-utilities', loadTypes }, { packageName: '@fluentui/dom-utilities', loadTypes }, @@ -81,8 +79,9 @@ if (typesContext) { hooksGroup.packages.push({ packageName: '@fluentui/react-hooks', loadTypes }); exampleDataGroup.packages.push({ packageName: '@fluentui/example-data', loadTypes }); } -const loadTypes = () => ''; -chartingGroup.packages.push({ packageName: '@fluentui/react-charting', loadTypes }); +if (window.location.href.indexOf('react-charting') !== -1) { + chartingGroup.packages.push({ packageName: '@fluentui/react-charting', loadTypes }); +} /** * Default supported packages for imports: `@fluentui/react` and everything it exports, From e3b70d3142638529346cec8ae0c811b022f437bb Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Mon, 17 Apr 2023 21:51:47 +0530 Subject: [PATCH 11/16] Update line chart color --- .../react-charting/src/components/LineChart/LineChart.base.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-charting/src/components/LineChart/LineChart.base.tsx b/packages/react-charting/src/components/LineChart/LineChart.base.tsx index 9997fa01973ee4..3e5d4492fc0f16 100644 --- a/packages/react-charting/src/components/LineChart/LineChart.base.tsx +++ b/packages/react-charting/src/components/LineChart/LineChart.base.tsx @@ -277,7 +277,7 @@ export class LineChartBase extends React.Component Date: Mon, 17 Apr 2023 22:13:12 +0530 Subject: [PATCH 12/16] Add null check for window --- .../src/utilities/defaultSupportedPackages.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts index 699f8838fb56ba..095f1923d44a76 100644 --- a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts +++ b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts @@ -79,7 +79,7 @@ if (typesContext) { hooksGroup.packages.push({ packageName: '@fluentui/react-hooks', loadTypes }); exampleDataGroup.packages.push({ packageName: '@fluentui/example-data', loadTypes }); } -if (window.location.href.indexOf('react-charting') !== -1) { +if (window && window.location.href.indexOf('react-charting') !== -1) { chartingGroup.packages.push({ packageName: '@fluentui/react-charting', loadTypes }); } From b4ce7c14f7fcb88d13fa7548bc643afb71a7194d Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Tue, 18 Apr 2023 12:04:05 +0530 Subject: [PATCH 13/16] Add undefined check --- .../src/utilities/defaultSupportedPackages.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts index 095f1923d44a76..882159bace9946 100644 --- a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts +++ b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts @@ -79,7 +79,7 @@ if (typesContext) { hooksGroup.packages.push({ packageName: '@fluentui/react-hooks', loadTypes }); exampleDataGroup.packages.push({ packageName: '@fluentui/example-data', loadTypes }); } -if (window && window.location.href.indexOf('react-charting') !== -1) { +if (window !== undefined && window.location.href.indexOf('react-charting') !== -1) { chartingGroup.packages.push({ packageName: '@fluentui/react-charting', loadTypes }); } From 4b852aae283173cb651bd631b8179e0cc26f6c1f Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Tue, 18 Apr 2023 13:12:59 +0530 Subject: [PATCH 14/16] Line chart changes --- .../react-charting/src/components/LineChart/LineChart.base.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-charting/src/components/LineChart/LineChart.base.tsx b/packages/react-charting/src/components/LineChart/LineChart.base.tsx index 3e5d4492fc0f16..c3b7c82b1af2e0 100644 --- a/packages/react-charting/src/components/LineChart/LineChart.base.tsx +++ b/packages/react-charting/src/components/LineChart/LineChart.base.tsx @@ -100,7 +100,7 @@ const _getPointPath = (x: number, y: number, w: number, index: number): string = L${x + 0.6884 * w} ${y - 0.2633 * w} L${x + 0.5001 * w} ${y + 0.6884 * w} L${x - 0.5001 * w} ${y + 0.6884 * w} - L${x - 0.6884 * w} ${y - 0.2633 * w} + L${x - 0.6884 * w} ${y - 0.263 * w} Z`, //octagon `M${x - 0.5001 * w} ${y - 1.207 * w} From b9c69448bbacb21b1dc4322d45fb934052f4efcc Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Tue, 18 Apr 2023 14:06:50 +0530 Subject: [PATCH 15/16] Fix window typeof --- .../src/utilities/defaultSupportedPackages.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts index 882159bace9946..1a096a6ada1447 100644 --- a/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts +++ b/packages/react-monaco-editor/src/utilities/defaultSupportedPackages.ts @@ -79,7 +79,7 @@ if (typesContext) { hooksGroup.packages.push({ packageName: '@fluentui/react-hooks', loadTypes }); exampleDataGroup.packages.push({ packageName: '@fluentui/example-data', loadTypes }); } -if (window !== undefined && window.location.href.indexOf('react-charting') !== -1) { +if (typeof window === 'object' && window.location.href.indexOf('react-charting') !== -1) { chartingGroup.packages.push({ packageName: '@fluentui/react-charting', loadTypes }); } From 3babbf19b34d6f60aab090f27c41d2fccce67751 Mon Sep 17 00:00:00 2001 From: "Atishay Jain (atisjai)" Date: Wed, 26 Apr 2023 09:55:01 +0530 Subject: [PATCH 16/16] Revert test changes --- ...eact-charting-b2276f17-5bf5-4574-8ed6-a32817b67107.json | 7 ------- packages/react-charting/src/components/Legends/shape.tsx | 2 +- .../src/components/LineChart/LineChart.base.tsx | 7 +------ 3 files changed, 2 insertions(+), 14 deletions(-) delete mode 100644 change/@fluentui-react-charting-b2276f17-5bf5-4574-8ed6-a32817b67107.json diff --git a/change/@fluentui-react-charting-b2276f17-5bf5-4574-8ed6-a32817b67107.json b/change/@fluentui-react-charting-b2276f17-5bf5-4574-8ed6-a32817b67107.json deleted file mode 100644 index c7c967ff912017..00000000000000 --- a/change/@fluentui-react-charting-b2276f17-5bf5-4574-8ed6-a32817b67107.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "type": "patch", - "comment": "Fix shape of triangle and pyramid", - "packageName": "@fluentui/react-charting", - "email": "atishay.jain@microsoft.com", - "dependentChangeType": "patch" -} diff --git a/packages/react-charting/src/components/Legends/shape.tsx b/packages/react-charting/src/components/Legends/shape.tsx index a0a6777862e87e..91cd3135771417 100644 --- a/packages/react-charting/src/components/Legends/shape.tsx +++ b/packages/react-charting/src/components/Legends/shape.tsx @@ -36,7 +36,7 @@ export const Shape: React.FC = ({ svgProps, pathProps, shape, class height={14} viewBox={'-1 -1 14 14'} {...svgProps} - transform={`rotate(${shape === Points[Points.diamond] ? 45 : shape === Points[Points.pyramid] ? 180 : 0}, 0, 0)`} + transform={`rotate(${shape === Points[Points.diamond] ? 45 : shape === Points[Points.triangle] ? 180 : 0}, 0, 0)`} > diff --git a/packages/react-charting/src/components/LineChart/LineChart.base.tsx b/packages/react-charting/src/components/LineChart/LineChart.base.tsx index c3b7c82b1af2e0..86a5db5dbcd80a 100644 --- a/packages/react-charting/src/components/LineChart/LineChart.base.tsx +++ b/packages/react-charting/src/components/LineChart/LineChart.base.tsx @@ -100,7 +100,7 @@ const _getPointPath = (x: number, y: number, w: number, index: number): string = L${x + 0.6884 * w} ${y - 0.2633 * w} L${x + 0.5001 * w} ${y + 0.6884 * w} L${x - 0.5001 * w} ${y + 0.6884 * w} - L${x - 0.6884 * w} ${y - 0.263 * w} + L${x - 0.6884 * w} ${y - 0.2633 * w} Z`, //octagon `M${x - 0.5001 * w} ${y - 1.207 * w} @@ -547,10 +547,6 @@ export class LineChartBase extends React.Component { - this._refCallback(e!, circleId); - }} onMouseOver={this._handleHover.bind( this, x1, @@ -569,7 +565,6 @@ export class LineChartBase extends React.Component this._handleFocus(circleId, x1, xAxisCalloutData, circleId, xAxisCalloutAccessibilityData)} onMouseOut={this._handleMouseOut} strokeWidth={activePoint === circleId ? DEFAULT_LINE_STROKE_SIZE : 0} stroke={activePoint === circleId ? lineColor : ''}