From ef9bf7e7d03f22a224a84614a032269f69d5dc71 Mon Sep 17 00:00:00 2001 From: Shubhabrata Ghosh Date: Thu, 26 Oct 2023 15:03:32 +0530 Subject: [PATCH 1/2] Added scale factor to min Height value --- .../VerticalStackedBarChart/VerticalStackedBarChart.base.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx b/packages/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx index 3b4ac0c6d637f1..5984faffac9f0e 100644 --- a/packages/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx +++ b/packages/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx @@ -790,8 +790,8 @@ export class VerticalStackedBarChartBase extends React.Component< }; let barHeight = heightValueScale * point.data; - if (barHeight < Math.max(Math.ceil(this._yMax / 100.0), barMinimumHeight)) { - barHeight = Math.max(Math.ceil(this._yMax / 100.0), barMinimumHeight); + if (barHeight < Math.max(heightValueScale * Math.ceil(this._yMax / 100.0), barMinimumHeight)) { + barHeight = Math.max(heightValueScale * Math.ceil(this._yMax / 100.0), barMinimumHeight); } yPoint = yPoint - barHeight - (index ? gapHeight : 0); barTotalValue += point.data; From 277ce2415cd1b0252a36166e7a456f0f5dac06a6 Mon Sep 17 00:00:00 2001 From: Shubhabrata Ghosh Date: Thu, 26 Oct 2023 15:47:36 +0530 Subject: [PATCH 2/2] Changefile added --- ...eact-charting-558ce73b-bb6f-475f-be32-1aa78f0663a0.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-charting-558ce73b-bb6f-475f-be32-1aa78f0663a0.json diff --git a/change/@fluentui-react-charting-558ce73b-bb6f-475f-be32-1aa78f0663a0.json b/change/@fluentui-react-charting-558ce73b-bb6f-475f-be32-1aa78f0663a0.json new file mode 100644 index 00000000000000..606946386a527a --- /dev/null +++ b/change/@fluentui-react-charting-558ce73b-bb6f-475f-be32-1aa78f0663a0.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Added scale factor to minimum height logic", + "packageName": "@fluentui/react-charting", + "email": "shubhabrata08@gmail.com", + "dependentChangeType": "patch" +}