From 2fdfcebb484f743bbec449aa8b73b082d895af98 Mon Sep 17 00:00:00 2001 From: Tomi Olubeko Date: Tue, 9 Apr 2024 07:30:46 -0700 Subject: [PATCH 1/6] Update IconDirectionContextProvider import to import from specific path --- .../src/components/FluentProvider/FluentProvider.types.ts | 2 +- .../src/components/FluentProvider/renderFluentProvider.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts b/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts index e5f41f495076b..a045de774e9c3 100644 --- a/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts +++ b/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts @@ -1,4 +1,4 @@ -import type { IconDirectionContextValue } from '@fluentui/react-icons'; +import type { IconDirectionContextValue } from '@fluentui/react-icons/providers'; import type { OverridesContextValue_unstable as OverridesContextValue, ProviderContextValue_unstable as ProviderContextValue, diff --git a/packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx b/packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx index b5a5a03713785..f0c93eb4b1abc 100644 --- a/packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx +++ b/packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx @@ -12,7 +12,7 @@ import { CustomStyleHooksContextValue_unstable as CustomStyleHooksContextValue, } from '@fluentui/react-shared-contexts'; import type { FluentProviderContextValues, FluentProviderState, FluentProviderSlots } from './FluentProvider.types'; -import { IconDirectionContextProvider } from '@fluentui/react-icons'; +import { IconDirectionContextProvider } from '@fluentui/react-icons/providers'; /** * Render the final JSX of FluentProvider From 8dbaf252500ea7e324365e268cebf799b4f0656e Mon Sep 17 00:00:00 2001 From: Tomi Olubeko Date: Tue, 9 Apr 2024 07:36:18 -0700 Subject: [PATCH 2/6] change file --- ...eact-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json diff --git a/change/@fluentui-react-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json b/change/@fluentui-react-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json new file mode 100644 index 0000000000000..4ed7a8fb2cb6e --- /dev/null +++ b/change/@fluentui-react-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "chore: Update IconDirectionContextProvider imports to use export map", + "packageName": "@fluentui/react-provider", + "email": "ololubek@microsoft.com", + "dependentChangeType": "patch" +} From a15d8a65d6cb01bc5708b28a5f6a7bb4274ea248 Mon Sep 17 00:00:00 2001 From: Tomi Olubeko Date: Mon, 22 Apr 2024 11:55:07 -0700 Subject: [PATCH 3/6] update import to use lib --- .../src/components/FluentProvider/renderFluentProvider.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx b/packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx index f0c93eb4b1abc..60b86a1f96049 100644 --- a/packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx +++ b/packages/react-components/react-provider/src/components/FluentProvider/renderFluentProvider.tsx @@ -12,7 +12,7 @@ import { CustomStyleHooksContextValue_unstable as CustomStyleHooksContextValue, } from '@fluentui/react-shared-contexts'; import type { FluentProviderContextValues, FluentProviderState, FluentProviderSlots } from './FluentProvider.types'; -import { IconDirectionContextProvider } from '@fluentui/react-icons/providers'; +import { IconDirectionContextProvider } from '@fluentui/react-icons/lib/providers'; /** * Render the final JSX of FluentProvider From c3279a9d04779069eca0c64ae677550ebb186974 Mon Sep 17 00:00:00 2001 From: Tomi Olubeko Date: Tue, 23 Apr 2024 01:12:40 -0700 Subject: [PATCH 4/6] update import path for types file --- .../src/components/FluentProvider/FluentProvider.types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts b/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts index a045de774e9c3..ce79551e9b060 100644 --- a/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts +++ b/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts @@ -1,4 +1,4 @@ -import type { IconDirectionContextValue } from '@fluentui/react-icons/providers'; +import type { IconDirectionContextValue } from '@fluentui/react-icons/lib/providers'; import type { OverridesContextValue_unstable as OverridesContextValue, ProviderContextValue_unstable as ProviderContextValue, From 23aa354a3799028cd94128a1f3a6b7129a85d2cc Mon Sep 17 00:00:00 2001 From: Tomi Olubeko Date: Tue, 30 Apr 2024 15:36:21 -0700 Subject: [PATCH 5/6] api update --- .../react-components/react-provider/etc/react-provider.api.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/react-components/react-provider/etc/react-provider.api.md b/packages/react-components/react-provider/etc/react-provider.api.md index fce116d19f2be..550ddb8f20b07 100644 --- a/packages/react-components/react-provider/etc/react-provider.api.md +++ b/packages/react-components/react-provider/etc/react-provider.api.md @@ -4,12 +4,10 @@ ```ts -/// - import { ComponentProps } from '@fluentui/react-utilities'; import type { ComponentState } from '@fluentui/react-utilities'; import type { CustomStyleHooksContextValue_unstable } from '@fluentui/react-shared-contexts'; -import type { IconDirectionContextValue } from '@fluentui/react-icons'; +import type { IconDirectionContextValue } from '@fluentui/react-icons/lib/providers'; import { OverridesContextValue_unstable } from '@fluentui/react-shared-contexts'; import type { PartialTheme } from '@fluentui/react-theme'; import type { ProviderContextValue_unstable } from '@fluentui/react-shared-contexts'; From d0da31c23165d65b157fe3792ed553a335b78fc1 Mon Sep 17 00:00:00 2001 From: Tomi Olubeko Date: Wed, 22 May 2024 13:32:20 -0700 Subject: [PATCH 6/6] apply suggestions from code review --- ...-react-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json | 2 +- .../src/components/FluentProvider/FluentProvider.types.ts | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/change/@fluentui-react-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json b/change/@fluentui-react-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json index 4ed7a8fb2cb6e..b6184b55e41f7 100644 --- a/change/@fluentui-react-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json +++ b/change/@fluentui-react-provider-b4ae6507-5ab8-4993-a09e-817306d5b73e.json @@ -1,6 +1,6 @@ { "type": "patch", - "comment": "chore: Update IconDirectionContextProvider imports to use export map", + "comment": "fix: Update IconDirectionContextProvider imports to use export map", "packageName": "@fluentui/react-provider", "email": "ololubek@microsoft.com", "dependentChangeType": "patch" diff --git a/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts b/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts index ce79551e9b060..4820905d6c014 100644 --- a/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts +++ b/packages/react-components/react-provider/src/components/FluentProvider/FluentProvider.types.ts @@ -1,3 +1,8 @@ +/* + IconDirectionContextValue is being imported as a leaf node import in order to prevent extra icons froms being + downloaded when trying to use the FluentProvider. + This issue has more context: https://github.com/microsoft/fluentui/issues/30909 +*/ import type { IconDirectionContextValue } from '@fluentui/react-icons/lib/providers'; import type { OverridesContextValue_unstable as OverridesContextValue,