From fb493a56bd66b9489f59f33fff9ba1183b9dc9e8 Mon Sep 17 00:00:00 2001 From: Martin Hochel Date: Wed, 5 Feb 2025 14:25:45 +0100 Subject: [PATCH 1/7] fix(vr-tests-rc): make storywright in page evaluation work for parsing steps metadata --- apps/vr-tests-react-components/.storybook/main.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/vr-tests-react-components/.storybook/main.js b/apps/vr-tests-react-components/.storybook/main.js index 0d8d34b1fd5f3..51f401ff7215f 100644 --- a/apps/vr-tests-react-components/.storybook/main.js +++ b/apps/vr-tests-react-components/.storybook/main.js @@ -53,4 +53,7 @@ module.exports = /** @type {import('@storybook/react-webpack5').StorybookConfig} }, }; }, + features: { + storyStoreV7: false, + }, }); From 77a35c1a8758a42c66759a8d13c0f6b78ceb86eb Mon Sep 17 00:00:00 2001 From: Martin Hochel Date: Wed, 5 Feb 2025 15:01:44 +0100 Subject: [PATCH 2/7] fix(vr-tests-rc): remove invalid cropTo selectors for stories that don't render it --- .../Button/CompoundButtonDefault.stories.tsx | 2 +- .../src/stories/Button/utils.ts | 6 ++--- .../ColorPicker/ColorPicker.stories.tsx | 4 +--- .../src/stories/Image/Image.stories.tsx | 4 +--- .../src/stories/Label.stories.tsx | 4 +--- .../stories/MessageBar/MessageBar.stories.tsx | 22 ++++++++++--------- .../ShadowDOM/ShadowDOMDefault.stories.tsx | 2 +- .../ShadowDOM/ShadowDOMPortal.stories.tsx | 2 +- .../SwatchPicker/SwatchPicker.stories.tsx | 4 +--- .../src/stories/Tabs.stories.tsx | 6 ++--- .../stories/Tag/InteractionTag.stories.tsx | 2 +- .../Tag/InteractionTagAppearances.stories.tsx | 10 ++++----- .../Tag/InteractionTagShape.stories.tsx | 6 ++--- .../src/stories/Tag/Tag.stories.tsx | 2 +- .../stories/Tag/TagAppearances.stories.tsx | 6 ++--- .../src/stories/Tag/TagGroup.stories.tsx | 2 +- .../src/stories/Tag/TagShape.stories.tsx | 4 ++-- 17 files changed, 41 insertions(+), 47 deletions(-) diff --git a/apps/vr-tests-react-components/src/stories/Button/CompoundButtonDefault.stories.tsx b/apps/vr-tests-react-components/src/stories/Button/CompoundButtonDefault.stories.tsx index 95881ec32b35f..dfc97365658c1 100644 --- a/apps/vr-tests-react-components/src/stories/Button/CompoundButtonDefault.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Button/CompoundButtonDefault.stories.tsx @@ -14,7 +14,7 @@ const steps = new Steps() // .hover('#button-id') // .snapshot('hover', { cropTo: '.testWrapper' }) .mouseDown('#button-id') - .snapshot('pressed', { cropTo: '.testWrapper' }) + .snapshot('pressed') .end(); export default { diff --git a/apps/vr-tests-react-components/src/stories/Button/utils.ts b/apps/vr-tests-react-components/src/stories/Button/utils.ts index 651478afafb80..67e1161345acf 100644 --- a/apps/vr-tests-react-components/src/stories/Button/utils.ts +++ b/apps/vr-tests-react-components/src/stories/Button/utils.ts @@ -10,9 +10,9 @@ export const useStyles = makeStyles({ }); export const steps = new Steps() - .snapshot('default', { cropTo: '.testWrapper' }) + .snapshot('default') .hover('#button-id') - .snapshot('hover', { cropTo: '.testWrapper' }) + .snapshot('hover') .mouseDown('#button-id') - .snapshot('pressed', { cropTo: '.testWrapper' }) + .snapshot('pressed') .end(); diff --git a/apps/vr-tests-react-components/src/stories/ColorPicker/ColorPicker.stories.tsx b/apps/vr-tests-react-components/src/stories/ColorPicker/ColorPicker.stories.tsx index 174df5aae6913..6e1268a49e1d8 100644 --- a/apps/vr-tests-react-components/src/stories/ColorPicker/ColorPicker.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/ColorPicker/ColorPicker.stories.tsx @@ -8,9 +8,7 @@ import { DARK_MODE, getStoryVariant, HIGH_CONTRAST, RTL, withStoryWrightSteps } export default { title: 'ColorPicker Converged', - decorators: [ - story => withStoryWrightSteps({ story, steps: new Steps().snapshot('default', { cropTo: '.testWrapper' }).end() }), - ], + decorators: [story => withStoryWrightSteps({ story, steps: new Steps().snapshot('default').end() })], } satisfies Meta; export const Default = () => ; diff --git a/apps/vr-tests-react-components/src/stories/Image/Image.stories.tsx b/apps/vr-tests-react-components/src/stories/Image/Image.stories.tsx index ea795f5994ba8..b1fdd6cc8135e 100644 --- a/apps/vr-tests-react-components/src/stories/Image/Image.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Image/Image.stories.tsx @@ -9,9 +9,7 @@ export default { title: 'Image Converged', decorators: [ - (story: () => React.ReactNode) => ( - {story()} - ), + (story: () => React.ReactNode) => {story()}, ], } satisfies Meta; diff --git a/apps/vr-tests-react-components/src/stories/Label.stories.tsx b/apps/vr-tests-react-components/src/stories/Label.stories.tsx index 08919a31d4367..1315aa7d09925 100644 --- a/apps/vr-tests-react-components/src/stories/Label.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Label.stories.tsx @@ -7,9 +7,7 @@ import { DARK_MODE, getStoryVariant, HIGH_CONTRAST, RTL, withStoryWrightSteps } export default { title: 'Label Converged', - decorators: [ - story => withStoryWrightSteps({ story, steps: new Steps().snapshot('default', { cropTo: '.testWrapper' }).end() }), - ], + decorators: [story => withStoryWrightSteps({ story, steps: new Steps().snapshot('default').end() })], } satisfies Meta; export const Root = () => ; diff --git a/apps/vr-tests-react-components/src/stories/MessageBar/MessageBar.stories.tsx b/apps/vr-tests-react-components/src/stories/MessageBar/MessageBar.stories.tsx index b0d4d0cc5bf36..37171428d14ec 100644 --- a/apps/vr-tests-react-components/src/stories/MessageBar/MessageBar.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/MessageBar/MessageBar.stories.tsx @@ -124,15 +124,17 @@ export const Auto = () => { export const Square = () => { return ( - - - Title - Message providing information to the user with actionable insights. Link - - } />}> - - - - +
+ + + Title + Message providing information to the user with actionable insights. Link + + } />}> + + + + +
); }; diff --git a/apps/vr-tests-react-components/src/stories/ShadowDOM/ShadowDOMDefault.stories.tsx b/apps/vr-tests-react-components/src/stories/ShadowDOM/ShadowDOMDefault.stories.tsx index 2ac6ca52265ef..7417a564b7da3 100644 --- a/apps/vr-tests-react-components/src/stories/ShadowDOM/ShadowDOMDefault.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/ShadowDOM/ShadowDOMDefault.stories.tsx @@ -41,7 +41,7 @@ export default { }; export const Default = () => ( - + diff --git a/apps/vr-tests-react-components/src/stories/ShadowDOM/ShadowDOMPortal.stories.tsx b/apps/vr-tests-react-components/src/stories/ShadowDOM/ShadowDOMPortal.stories.tsx index 09e443803c516..15442ac31c509 100644 --- a/apps/vr-tests-react-components/src/stories/ShadowDOM/ShadowDOMPortal.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/ShadowDOM/ShadowDOMPortal.stories.tsx @@ -10,7 +10,7 @@ export default { }; export const Portal: React.FC = () => ( - + diff --git a/apps/vr-tests-react-components/src/stories/SwatchPicker/SwatchPicker.stories.tsx b/apps/vr-tests-react-components/src/stories/SwatchPicker/SwatchPicker.stories.tsx index 9b91ede32dd3c..16d4c7e661656 100644 --- a/apps/vr-tests-react-components/src/stories/SwatchPicker/SwatchPicker.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/SwatchPicker/SwatchPicker.stories.tsx @@ -8,9 +8,7 @@ import { DARK_MODE, getStoryVariant, HIGH_CONTRAST, RTL, withStoryWrightSteps } export default { title: 'SwatchPicker Converged', - decorators: [ - story => withStoryWrightSteps({ story, steps: new Steps().snapshot('default', { cropTo: '.testWrapper' }).end() }), - ], + decorators: [story => withStoryWrightSteps({ story, steps: new Steps().snapshot('default').end() })], } satisfies Meta; export const Default = () => ( diff --git a/apps/vr-tests-react-components/src/stories/Tabs.stories.tsx b/apps/vr-tests-react-components/src/stories/Tabs.stories.tsx index 409afb8012da8..d7cd382029b1e 100644 --- a/apps/vr-tests-react-components/src/stories/Tabs.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Tabs.stories.tsx @@ -13,11 +13,11 @@ export default { withStoryWrightSteps({ story, steps: new Steps() - .snapshot('default', { cropTo: '.testWrapper' }) + .snapshot('default') .hover('.mouse-target') - .snapshot('hover', { cropTo: '.testWrapper' }) + .snapshot('hover') .mouseDown('.mouse-target') - .snapshot('pressed', { cropTo: '.testWrapper' }) + .snapshot('pressed') .mouseUp('.mouse-target') .end(), }), diff --git a/apps/vr-tests-react-components/src/stories/Tag/InteractionTag.stories.tsx b/apps/vr-tests-react-components/src/stories/Tag/InteractionTag.stories.tsx index 42a839348865f..373d4a70796d4 100644 --- a/apps/vr-tests-react-components/src/stories/Tag/InteractionTag.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Tag/InteractionTag.stories.tsx @@ -9,7 +9,7 @@ import { makeStyles } from '@griffel/react'; const CalendarMonth = bundleIcon(CalendarMonthFilled, CalendarMonthRegular); -const steps = new Steps().snapshot('default', { cropTo: '.testWrapper' }).end(); +const steps = new Steps().snapshot('default').end(); export default { title: 'InteractionTag Converged', diff --git a/apps/vr-tests-react-components/src/stories/Tag/InteractionTagAppearances.stories.tsx b/apps/vr-tests-react-components/src/stories/Tag/InteractionTagAppearances.stories.tsx index 681b0c8fc5776..6e6270225d672 100644 --- a/apps/vr-tests-react-components/src/stories/Tag/InteractionTagAppearances.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Tag/InteractionTagAppearances.stories.tsx @@ -10,16 +10,16 @@ const CalendarMonth = bundleIcon(CalendarMonthFilled, CalendarMonthRegular); const contentId = 'content-id'; const dismissButtonId = 'dismiss-button-id'; const steps = new Steps() - .snapshot('default', { cropTo: '.testWrapper' }) + .snapshot('default') .hover(`#${contentId}`) - .snapshot('hover content', { cropTo: '.testWrapper' }) + .snapshot('hover content') .mouseDown(`#${contentId}`) - .snapshot('pressed content', { cropTo: '.testWrapper' }) + .snapshot('pressed content') .mouseUp(`#${contentId}`) .hover(`#${dismissButtonId}`) - .snapshot('hover dismiss', { cropTo: '.testWrapper' }) + .snapshot('hover dismiss') .mouseDown(`#${dismissButtonId}`) - .snapshot('pressed dismiss', { cropTo: '.testWrapper' }) + .snapshot('pressed dismiss') .mouseUp(`#${dismissButtonId}`) .end(); diff --git a/apps/vr-tests-react-components/src/stories/Tag/InteractionTagShape.stories.tsx b/apps/vr-tests-react-components/src/stories/Tag/InteractionTagShape.stories.tsx index 7b539a470bbd6..33d21f8c3494f 100644 --- a/apps/vr-tests-react-components/src/stories/Tag/InteractionTagShape.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Tag/InteractionTagShape.stories.tsx @@ -8,18 +8,18 @@ import { Steps } from 'storywright'; const contentId = 'content-id'; const dismissButtonId = 'dismiss-button-id'; const steps = new Steps() - .snapshot('default', { cropTo: '.testWrapper' }) + .snapshot('default') // This needs to be added so that the focus outline is shown correctly .executeScript(`document.querySelector('#${contentId}').setAttribute('data-fui-focus-visible', '')`) .focus(`#${contentId}`) - .snapshot('focus content', { cropTo: '.testWrapper' }) + .snapshot('focus content') .executeScript(`document.querySelector('#${contentId}').removeAttribute('data-fui-focus-visible')`) // This needs to be added so that the focus outline is shown correctly .executeScript(`document.querySelector('#${dismissButtonId}').setAttribute('data-fui-focus-visible', '')`) .focus(`#${dismissButtonId}`) - .snapshot('focus dismiss', { cropTo: '.testWrapper' }) + .snapshot('focus dismiss') .executeScript(`document.querySelector('#${dismissButtonId}').removeAttribute('data-fui-focus-visible')`) .end(); diff --git a/apps/vr-tests-react-components/src/stories/Tag/Tag.stories.tsx b/apps/vr-tests-react-components/src/stories/Tag/Tag.stories.tsx index bde3970f43ea8..b028df283f9d6 100644 --- a/apps/vr-tests-react-components/src/stories/Tag/Tag.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Tag/Tag.stories.tsx @@ -8,7 +8,7 @@ import { Steps } from 'storywright'; const CalendarMonth = bundleIcon(CalendarMonthFilled, CalendarMonthRegular); -const steps = new Steps().snapshot('default', { cropTo: '.testWrapper' }).end(); +const steps = new Steps().snapshot('default').end(); export default { title: 'Tag Converged', diff --git a/apps/vr-tests-react-components/src/stories/Tag/TagAppearances.stories.tsx b/apps/vr-tests-react-components/src/stories/Tag/TagAppearances.stories.tsx index 0310924ea9fbf..4d529cc33e1e7 100644 --- a/apps/vr-tests-react-components/src/stories/Tag/TagAppearances.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Tag/TagAppearances.stories.tsx @@ -9,11 +9,11 @@ const CalendarMonth = bundleIcon(CalendarMonthFilled, CalendarMonthRegular); const dismissIconId = 'dismiss-icon-id'; const steps = new Steps() - .snapshot('default', { cropTo: '.testWrapper' }) + .snapshot('default') .hover(`#${dismissIconId}}`) - .snapshot('hover', { cropTo: '.testWrapper' }) + .snapshot('hover') .mouseDown(`#${dismissIconId}}`) - .snapshot('pressed', { cropTo: '.testWrapper' }) + .snapshot('pressed') .end(); export default { diff --git a/apps/vr-tests-react-components/src/stories/Tag/TagGroup.stories.tsx b/apps/vr-tests-react-components/src/stories/Tag/TagGroup.stories.tsx index 961347ffbd30e..f24947feb4ae0 100644 --- a/apps/vr-tests-react-components/src/stories/Tag/TagGroup.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Tag/TagGroup.stories.tsx @@ -4,7 +4,7 @@ import type { Meta } from '@storybook/react'; import { Steps } from 'storywright'; import { withStoryWrightSteps } from '../../utilities'; -const steps = new Steps().snapshot('default', { cropTo: '.testWrapper' }).end(); +const steps = new Steps().snapshot('default').end(); export default { title: 'TagGroup Converged', diff --git a/apps/vr-tests-react-components/src/stories/Tag/TagShape.stories.tsx b/apps/vr-tests-react-components/src/stories/Tag/TagShape.stories.tsx index 2a0a461147187..c75840c8287e0 100644 --- a/apps/vr-tests-react-components/src/stories/Tag/TagShape.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Tag/TagShape.stories.tsx @@ -7,11 +7,11 @@ import { Steps } from 'storywright'; const tagId = 'tag-id'; const steps = new Steps() - .snapshot('default', { cropTo: '.testWrapper' }) + .snapshot('default') // This needs to be added so that the focus outline is shown correctly .executeScript(`document.querySelector('#${tagId}').setAttribute('data-fui-focus-visible', '')`) .focus(`#${tagId}`) - .snapshot('focused', { cropTo: '.testWrapper' }) + .snapshot('focused') .executeScript(`document.querySelector('#${tagId}').removeAttribute('data-fui-focus-visible')`) .end(); From 54772a1c84d141189462c9ee4a44a7729cb132de Mon Sep 17 00:00:00 2001 From: Martin Hochel Date: Wed, 5 Feb 2025 15:33:56 +0100 Subject: [PATCH 3/7] fixup! fix(vr-tests-rc): remove invalid cropTo selectors for stories that don't render it --- .../src/stories/Breadcrumb/utils.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/vr-tests-react-components/src/stories/Breadcrumb/utils.tsx b/apps/vr-tests-react-components/src/stories/Breadcrumb/utils.tsx index 490b3f09ec026..f9439b64fc540 100644 --- a/apps/vr-tests-react-components/src/stories/Breadcrumb/utils.tsx +++ b/apps/vr-tests-react-components/src/stories/Breadcrumb/utils.tsx @@ -11,13 +11,13 @@ import { bundleIcon, CalendarMonth20Filled, CalendarMonth20Regular } from '@flue const CalendarMonth = bundleIcon(CalendarMonth20Filled, CalendarMonth20Regular); export const steps = new Steps() - .snapshot('default', { cropTo: '.testWrapper' }) + .snapshot('default') .hover('.breadcrumb-sample') - .snapshot('hover', { cropTo: '.testWrapper' }) + .snapshot('hover') .mouseDown('.breadcrumb-sample') - .snapshot('pressed', { cropTo: '.testWrapper' }) + .snapshot('pressed') .focus('.breadcrumb-sample') - .snapshot('focused', { cropTo: '.testWrapper' }) + .snapshot('focused') .end(); export const SampleBreadcrumbButtons = (props: BreadcrumbProps) => ( From ddcd3522123c46015756734f65e40f7e290edc57 Mon Sep 17 00:00:00 2001 From: Martin Hochel Date: Wed, 5 Feb 2025 15:37:05 +0100 Subject: [PATCH 4/7] fixup! fixup! fix(vr-tests-rc): remove invalid cropTo selectors for stories that don't render it --- .../src/stories/Button/CompoundButtonDefault.stories.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/vr-tests-react-components/src/stories/Button/CompoundButtonDefault.stories.tsx b/apps/vr-tests-react-components/src/stories/Button/CompoundButtonDefault.stories.tsx index dfc97365658c1..ec4381c63ed6d 100644 --- a/apps/vr-tests-react-components/src/stories/Button/CompoundButtonDefault.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Button/CompoundButtonDefault.stories.tsx @@ -9,7 +9,7 @@ import { buttonId } from './utils'; const CalendarMonth = bundleIcon(CalendarMonthFilled, CalendarMonthRegular); const steps = new Steps() - .snapshot('default', { cropTo: '.testWrapper' }) + .snapshot('default') // https://github.com/microsoft/fluentui/issues/21998 // .hover('#button-id') // .snapshot('hover', { cropTo: '.testWrapper' }) From 5a80cd574ac971a9fd1d15e67b19920884a27044 Mon Sep 17 00:00:00 2001 From: Martin Hochel Date: Wed, 5 Feb 2025 15:52:26 +0100 Subject: [PATCH 5/7] fixup! fix(vr-tests-rc): make storywright in page evaluation work for parsing steps metadata --- apps/vr-tests-react-components/.storybook/main.js | 1 + apps/vr-tests-web-components/.storybook/main.cjs | 4 ++++ apps/vr-tests/.storybook/main.js | 4 ++++ 3 files changed, 9 insertions(+) diff --git a/apps/vr-tests-react-components/.storybook/main.js b/apps/vr-tests-react-components/.storybook/main.js index 51f401ff7215f..19d8aee43c4f2 100644 --- a/apps/vr-tests-react-components/.storybook/main.js +++ b/apps/vr-tests-react-components/.storybook/main.js @@ -53,6 +53,7 @@ module.exports = /** @type {import('@storybook/react-webpack5').StorybookConfig} }, }; }, + // 💡 NOTE: this is necessary for StoryWright. without this the current version "0.0.27-storybook7.9" wont take screenshots for Steps features: { storyStoreV7: false, }, diff --git a/apps/vr-tests-web-components/.storybook/main.cjs b/apps/vr-tests-web-components/.storybook/main.cjs index 3bab823e169d0..dd31bc585620f 100644 --- a/apps/vr-tests-web-components/.storybook/main.cjs +++ b/apps/vr-tests-web-components/.storybook/main.cjs @@ -85,4 +85,8 @@ module.exports = /** @type {import('@storybook/react-webpack5').StorybookConfig} return config; }, + // 💡 NOTE: this is necessary for StoryWright. without this the current version "0.0.27-storybook7.9" wont take screenshots for Steps + features: { + storyStoreV7: false, + }, }); diff --git a/apps/vr-tests/.storybook/main.js b/apps/vr-tests/.storybook/main.js index 9f3502a8326aa..b643483d25730 100644 --- a/apps/vr-tests/.storybook/main.js +++ b/apps/vr-tests/.storybook/main.js @@ -51,4 +51,8 @@ module.exports = /** @type {import('@storybook/react-webpack5').StorybookConfig} }, }; }, + // 💡 NOTE: this is necessary for StoryWright. without this the current version "0.0.27-storybook7.9" wont take screenshots for Steps + features: { + storyStoreV7: false, + }, }); From 4ad2a3f49dff4c60044b9851bff09faba4032c69 Mon Sep 17 00:00:00 2001 From: Martin Hochel Date: Wed, 5 Feb 2025 16:03:09 +0100 Subject: [PATCH 6/7] fixup! fixup! fixup! fix(vr-tests-rc): remove invalid cropTo selectors for stories that don't render it --- .../src/stories/Link/utils.tsx | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/vr-tests-react-components/src/stories/Link/utils.tsx b/apps/vr-tests-react-components/src/stories/Link/utils.tsx index 9ad2a30f1ac7a..dcb45302663bf 100644 --- a/apps/vr-tests-react-components/src/stories/Link/utils.tsx +++ b/apps/vr-tests-react-components/src/stories/Link/utils.tsx @@ -21,25 +21,25 @@ export const InvertedBackground: React.FC<{ children: React.ReactNode }> = ({ ch }; export const steps = new Steps() - .snapshot('default', { cropTo: '.testWrapper' }) + .snapshot('default') .hover('.fui-Link') - .snapshot('hover', { cropTo: '.testWrapper' }) + .snapshot('hover') // This needs to be added so that the focus outline is shown correctly .executeScript("document.getElementsByClassName('fui-Link')[0].setAttribute('data-fui-focus-visible', '')") .focus('.fui-Link') - .snapshot('focused', { cropTo: '.testWrapper' }) + .snapshot('focused') .executeScript("document.getElementsByClassName('fui-Link')[0].removeAttribute('data-fui-focus-visible')") .mouseDown('.fui-Link') - .snapshot('pressed', { cropTo: '.testWrapper' }) + .snapshot('pressed') .mouseUp('.fui-Link') .end(); // Disabled stories use steps without focus so they do not error out on the focused step. export const disabledUnfocusableSteps = new Steps() - .snapshot('default', { cropTo: '.testWrapper' }) + .snapshot('default') .hover('.fui-Link') - .snapshot('hover', { cropTo: '.testWrapper' }) + .snapshot('hover') .mouseDown('.fui-Link') - .snapshot('pressed', { cropTo: '.testWrapper' }) + .snapshot('pressed') .mouseUp('.fui-Link') .end(); From f551b8022dfce510e2a6c038de1affb4d7776888 Mon Sep 17 00:00:00 2001 From: Martin Hochel Date: Wed, 5 Feb 2025 16:28:23 +0100 Subject: [PATCH 7/7] fixup! fixup! fixup! fixup! fix(vr-tests-rc): remove invalid cropTo selectors for stories that don't render it --- .../src/stories/Textarea/TextareaInteractions.stories.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/vr-tests-react-components/src/stories/Textarea/TextareaInteractions.stories.tsx b/apps/vr-tests-react-components/src/stories/Textarea/TextareaInteractions.stories.tsx index 711e3b5f7e495..7536b4c2c9de3 100644 --- a/apps/vr-tests-react-components/src/stories/Textarea/TextareaInteractions.stories.tsx +++ b/apps/vr-tests-react-components/src/stories/Textarea/TextareaInteractions.stories.tsx @@ -18,7 +18,7 @@ export default { .snapshot('hover', { cropTo: '.testWrapper' }) .click('textarea') .wait(250) // needed for bottom focus border animation - .snapshot('focused', { cropTo: '.textWrapper' }) + .snapshot('focused', { cropTo: '.testWrapper' }) .end(), }), ],