From 9b5a84d73a4b429dffc6d4da9dbf629e805e6e16 Mon Sep 17 00:00:00 2001 From: Anush Date: Wed, 12 Nov 2025 10:52:06 +0530 Subject: [PATCH 1/3] fix legend order --- .../VerticalStackedBarChart/VerticalStackedBarChart.base.tsx | 2 +- .../VerticalStackedBarChart/VerticalStackedBarChart.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/charts/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx b/packages/charts/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx index c1f4428895572c..a58aacba2c91c6 100644 --- a/packages/charts/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx +++ b/packages/charts/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx @@ -707,7 +707,7 @@ export class VerticalStackedBarChartBase legendsOfLine.push(legend); }); } - const totalLegends: ILegend[] = legendsOfLine.concat(actions); + const totalLegends: ILegend[] = actions.concat(legendsOfLine); return ( Date: Wed, 12 Nov 2025 10:55:41 +0530 Subject: [PATCH 2/3] Add change file --- ...eact-charting-4f8e08b2-0b16-4f95-a37e-3c37c4bcb904.json | 7 +++++++ ...-react-charts-b9303617-253d-4830-bbb1-b4207ec9791a.json | 7 +++++++ 2 files changed, 14 insertions(+) create mode 100644 change/@fluentui-react-charting-4f8e08b2-0b16-4f95-a37e-3c37c4bcb904.json create mode 100644 change/@fluentui-react-charts-b9303617-253d-4830-bbb1-b4207ec9791a.json diff --git a/change/@fluentui-react-charting-4f8e08b2-0b16-4f95-a37e-3c37c4bcb904.json b/change/@fluentui-react-charting-4f8e08b2-0b16-4f95-a37e-3c37c4bcb904.json new file mode 100644 index 00000000000000..3cdca6b8bb3c1b --- /dev/null +++ b/change/@fluentui-react-charting-4f8e08b2-0b16-4f95-a37e-3c37c4bcb904.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "set reference line legends after the main chart legends", + "packageName": "@fluentui/react-charting", + "email": "anushgupta@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/change/@fluentui-react-charts-b9303617-253d-4830-bbb1-b4207ec9791a.json b/change/@fluentui-react-charts-b9303617-253d-4830-bbb1-b4207ec9791a.json new file mode 100644 index 00000000000000..545d1febb16d6a --- /dev/null +++ b/change/@fluentui-react-charts-b9303617-253d-4830-bbb1-b4207ec9791a.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "set reference line legends after the main chart legends", + "packageName": "@fluentui/react-charts", + "email": "anushgupta@microsoft.com", + "dependentChangeType": "patch" +} From 7c33c039aa24167de925748c7ca101f9ac7e7fd1 Mon Sep 17 00:00:00 2001 From: Anush Date: Wed, 12 Nov 2025 12:30:54 +0530 Subject: [PATCH 3/3] fix tests and update snapshots --- .../VerticalStackedBarChartRTL.test.tsx | 4 +- .../VerticalStackedBarChartRTL.test.tsx.snap | 176 +++++++++--------- .../VerticalStackedBarChart.test.tsx | 4 +- .../VerticalStackedBarChart.test.tsx.snap | 88 ++++----- 4 files changed, 136 insertions(+), 136 deletions(-) diff --git a/packages/charts/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChartRTL.test.tsx b/packages/charts/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChartRTL.test.tsx index b99d11103660ee..7b359bf0bf8912 100644 --- a/packages/charts/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChartRTL.test.tsx +++ b/packages/charts/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChartRTL.test.tsx @@ -413,7 +413,7 @@ describe('Vertical stacked bar chart - Subcomponent Legends', () => { const bars = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'rect'); const line = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'line'); const legends = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'button'); - fireEvent.mouseOver(legends[0]); + fireEvent.mouseOver(legends[3]); // Assert expect(line[8].getAttribute('opacity')).toEqual('1'); expect(bars[0]).toHaveStyle('opacity: 0.1'); @@ -436,7 +436,7 @@ describe('Vertical stacked bar chart - Subcomponent Legends', () => { const legends = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'button'); const bars = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'rect'); const line = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'line'); - fireEvent.mouseOver(legends![1]); + fireEvent.mouseOver(legends![0]); // Assert expect(line[8].getAttribute('opacity')).toEqual('0.1'); diff --git a/packages/charts/react-charting/src/components/VerticalStackedBarChart/__snapshots__/VerticalStackedBarChartRTL.test.tsx.snap b/packages/charts/react-charting/src/components/VerticalStackedBarChart/__snapshots__/VerticalStackedBarChartRTL.test.tsx.snap index d06bc8369943cc..a4aa96cb56048e 100644 --- a/packages/charts/react-charting/src/components/VerticalStackedBarChart/__snapshots__/VerticalStackedBarChartRTL.test.tsx.snap +++ b/packages/charts/react-charting/src/components/VerticalStackedBarChart/__snapshots__/VerticalStackedBarChartRTL.test.tsx.snap @@ -593,7 +593,7 @@ exports[`Vertical stacked bar chart - Screen resolution Should remain unchanged role="none" > @@ -693,7 +693,7 @@ exports[`Vertical stacked bar chart - Screen resolution Should remain unchanged role="none" > @@ -793,7 +793,7 @@ exports[`Vertical stacked bar chart - Screen resolution Should remain unchanged role="none" > @@ -893,7 +893,7 @@ exports[`Vertical stacked bar chart - Screen resolution Should remain unchanged role="none" > @@ -1587,7 +1587,7 @@ exports[`Vertical stacked bar chart - Screen resolution Should remain unchanged role="none" > @@ -1687,7 +1687,7 @@ exports[`Vertical stacked bar chart - Screen resolution Should remain unchanged role="none" > @@ -1787,7 +1787,7 @@ exports[`Vertical stacked bar chart - Screen resolution Should remain unchanged role="none" > @@ -1887,7 +1887,7 @@ exports[`Vertical stacked bar chart - Screen resolution Should remain unchanged role="none" > @@ -2581,7 +2581,7 @@ exports[`Vertical stacked bar chart - Subcomponent Line Should render the vertic role="none" > @@ -2681,7 +2681,7 @@ exports[`Vertical stacked bar chart - Subcomponent Line Should render the vertic role="none" > @@ -2781,7 +2781,7 @@ exports[`Vertical stacked bar chart - Subcomponent Line Should render the vertic role="none" > @@ -2881,7 +2881,7 @@ exports[`Vertical stacked bar chart - Subcomponent Line Should render the vertic role="none" > @@ -10372,7 +10372,7 @@ exports[`Vertical stacked bar chart rendering Should render the vertical stacked role="none" > @@ -10472,7 +10472,7 @@ exports[`Vertical stacked bar chart rendering Should render the vertical stacked role="none" > @@ -10572,7 +10572,7 @@ exports[`Vertical stacked bar chart rendering Should render the vertical stacked role="none" > @@ -10672,7 +10672,7 @@ exports[`Vertical stacked bar chart rendering Should render the vertical stacked role="none" > diff --git a/packages/charts/react-charts/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.test.tsx b/packages/charts/react-charts/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.test.tsx index 8dd5591f113eb3..c593ffcb5287c9 100644 --- a/packages/charts/react-charts/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.test.tsx +++ b/packages/charts/react-charts/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.test.tsx @@ -392,7 +392,7 @@ describe('Vertical stacked bar chart - Subcomponent Legends', () => { const bars = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'rect'); const line = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'line'); const legends = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'button'); - fireEvent.mouseOver(legends[0]); + fireEvent.mouseOver(legends[3]); // Assert expect(line[8].getAttribute('opacity')).toEqual('1'); expect(bars[0]).toHaveAttribute('opacity', '0.1'); @@ -415,7 +415,7 @@ describe('Vertical stacked bar chart - Subcomponent Legends', () => { const legends = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'button'); const bars = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'rect'); const line = screen.getAllByText((content, element) => element!.tagName.toLowerCase() === 'line'); - fireEvent.mouseOver(legends![1]); + fireEvent.mouseOver(legends![0]); // Assert expect(line[8].getAttribute('opacity')).toEqual('0.1'); diff --git a/packages/charts/react-charts/library/src/components/VerticalStackedBarChart/__snapshots__/VerticalStackedBarChart.test.tsx.snap b/packages/charts/react-charts/library/src/components/VerticalStackedBarChart/__snapshots__/VerticalStackedBarChart.test.tsx.snap index 0734251123cb0e..03f972bc22ca45 100644 --- a/packages/charts/react-charts/library/src/components/VerticalStackedBarChart/__snapshots__/VerticalStackedBarChart.test.tsx.snap +++ b/packages/charts/react-charts/library/src/components/VerticalStackedBarChart/__snapshots__/VerticalStackedBarChart.test.tsx.snap @@ -432,79 +432,79 @@ exports[`Vertical stacked bar chart - Screen resolution Should remain unchanged style="text-align: unset;" > @@ -946,79 +946,79 @@ exports[`Vertical stacked bar chart - Screen resolution Should remain unchanged style="text-align: unset;" > @@ -3145,21 +3145,21 @@ exports[`VerticalStackedBarChart - mouse events Should render customized callout class="fui-legend__legendContainer" > @@ -3167,21 +3167,21 @@ exports[`VerticalStackedBarChart - mouse events Should render customized callout class="fui-legend__legendContainer" > @@ -3189,21 +3189,21 @@ exports[`VerticalStackedBarChart - mouse events Should render customized callout class="fui-legend__legendContainer" >