From 5cf5071ca872693aff95f962869b0b1a117827b4 Mon Sep 17 00:00:00 2001 From: David Zearing Date: Thu, 29 Mar 2018 20:48:24 -0700 Subject: [PATCH 1/2] Temporarily disable tree shaking. --- packages/example-app-base/package.json | 2 +- packages/experiments/package.json | 2 +- packages/office-ui-fabric-react/package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/example-app-base/package.json b/packages/example-app-base/package.json index 7934eb518762c6..bf386d06f56a37 100644 --- a/packages/example-app-base/package.json +++ b/packages/example-app-base/package.json @@ -5,7 +5,7 @@ "main": "lib/index.js", "module": "lib-es2015/index.js", "typings": "lib-es2015/index.d.ts", - "sideEffects": false, + "sideEffects": true, "repository": { "type": "git", "url": "https://github.com/OfficeDev/office-ui-fabric-react" diff --git a/packages/experiments/package.json b/packages/experiments/package.json index 6c0175b3628cc6..3bd6a09b50201d 100644 --- a/packages/experiments/package.json +++ b/packages/experiments/package.json @@ -5,7 +5,7 @@ "main": "lib/index.js", "module": "lib-es2015/index.js", "typings": "lib-es2015/index.d.ts", - "sideEffects": false, + "sideEffects": true, "repository": { "type": "git", "url": "https://github.com/OfficeDev/office-ui-fabric-react" diff --git a/packages/office-ui-fabric-react/package.json b/packages/office-ui-fabric-react/package.json index 9214af1100bb3d..ca788fce98405a 100644 --- a/packages/office-ui-fabric-react/package.json +++ b/packages/office-ui-fabric-react/package.json @@ -5,7 +5,7 @@ "main": "lib/index.js", "module": "lib-es2015/index.js", "typings": "lib-es2015/index.d.ts", - "sideEffects": false, + "sideEffects": true, "repository": { "type": "git", "url": "https://github.com/OfficeDev/office-ui-fabric-react" From 8a264228ec790ec7b8e38b3275d7c9a55d7faf0b Mon Sep 17 00:00:00 2001 From: David Zearing Date: Thu, 29 Mar 2018 20:49:50 -0700 Subject: [PATCH 2/2] Adding change files. --- .../disable-tree-shaking_2018-03-30-03-49.json | 11 +++++++++++ .../disable-tree-shaking_2018-03-30-03-49.json | 11 +++++++++++ .../disable-tree-shaking_2018-03-30-03-49.json | 11 +++++++++++ 3 files changed, 33 insertions(+) create mode 100644 common/changes/@uifabric/example-app-base/disable-tree-shaking_2018-03-30-03-49.json create mode 100644 common/changes/@uifabric/experiments/disable-tree-shaking_2018-03-30-03-49.json create mode 100644 common/changes/office-ui-fabric-react/disable-tree-shaking_2018-03-30-03-49.json diff --git a/common/changes/@uifabric/example-app-base/disable-tree-shaking_2018-03-30-03-49.json b/common/changes/@uifabric/example-app-base/disable-tree-shaking_2018-03-30-03-49.json new file mode 100644 index 00000000000000..a0e130f2455070 --- /dev/null +++ b/common/changes/@uifabric/example-app-base/disable-tree-shaking_2018-03-30-03-49.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@uifabric/example-app-base", + "comment": "We need to temporarily remove `sideEffects: false` flag from package.json which will disable w", + "type": "patch" + } + ], + "packageName": "@uifabric/example-app-base", + "email": "dzearing@microsoft.com" +} \ No newline at end of file diff --git a/common/changes/@uifabric/experiments/disable-tree-shaking_2018-03-30-03-49.json b/common/changes/@uifabric/experiments/disable-tree-shaking_2018-03-30-03-49.json new file mode 100644 index 00000000000000..e68896d74913cb --- /dev/null +++ b/common/changes/@uifabric/experiments/disable-tree-shaking_2018-03-30-03-49.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@uifabric/experiments", + "comment": "We need to temporarily remove `sideEffects: false` flag from package.json which will disable w", + "type": "patch" + } + ], + "packageName": "@uifabric/experiments", + "email": "dzearing@microsoft.com" +} \ No newline at end of file diff --git a/common/changes/office-ui-fabric-react/disable-tree-shaking_2018-03-30-03-49.json b/common/changes/office-ui-fabric-react/disable-tree-shaking_2018-03-30-03-49.json new file mode 100644 index 00000000000000..04ab5668cc38c3 --- /dev/null +++ b/common/changes/office-ui-fabric-react/disable-tree-shaking_2018-03-30-03-49.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "We need to temporarily remove `sideEffects: false` flag from package.json which will disable webpack 4 tree shaking until we can identify a good fix for it to not shake out the scss files.", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "dzearing@microsoft.com" +} \ No newline at end of file