From 8560010d951433bd159ee06dd664599ebef53df8 Mon Sep 17 00:00:00 2001 From: Mark Polak Date: Sat, 14 Apr 2018 12:08:10 +0200 Subject: [PATCH 1/4] Do not call onMenuClick on every keyDown --- .../src/components/Button/BaseButton.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx b/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx index 06c66aee2304b6..5531c0a38326cb 100644 --- a/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx +++ b/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx @@ -570,14 +570,14 @@ export class BaseButton extends BaseComponent Date: Sat, 14 Apr 2018 12:09:47 +0200 Subject: [PATCH 2/4] Add change file --- ...ick-firing-on-every-key-down_2018-04-14-10-09.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/mapol-fix-onMenuClick-firing-on-every-key-down_2018-04-14-10-09.json diff --git a/common/changes/office-ui-fabric-react/mapol-fix-onMenuClick-firing-on-every-key-down_2018-04-14-10-09.json b/common/changes/office-ui-fabric-react/mapol-fix-onMenuClick-firing-on-every-key-down_2018-04-14-10-09.json new file mode 100644 index 00000000000000..ea531e6888d2f8 --- /dev/null +++ b/common/changes/office-ui-fabric-react/mapol-fix-onMenuClick-firing-on-every-key-down_2018-04-14-10-09.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "Do not call the onMenuClick on every keyDown event", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "mark@thedutchies.com" +} \ No newline at end of file From f47ec6cb975777c9f5d78ae9b7cdd34606d637ad Mon Sep 17 00:00:00 2001 From: Mark Polak Date: Sun, 15 Apr 2018 19:45:21 +0200 Subject: [PATCH 3/4] Simplify if condition --- .../office-ui-fabric-react/src/components/Button/BaseButton.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx b/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx index 5531c0a38326cb..9cfd0cec940451 100644 --- a/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx +++ b/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx @@ -571,7 +571,7 @@ export class BaseButton extends BaseComponent Date: Mon, 16 Apr 2018 18:42:41 +0200 Subject: [PATCH 4/4] Don't ignore default key down handling --- .../office-ui-fabric-react/src/components/Button/BaseButton.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx b/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx index 9cfd0cec940451..7cbdaeca15f986 100644 --- a/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx +++ b/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx @@ -571,7 +571,6 @@ export class BaseButton extends BaseComponent